-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update check_conditions() #1294
Commits on Jun 15, 2023
-
Fix ConsIndShockSolver choice and calc_bounding_values
ConsIndShockSolver is always chosen now, and calc_bounding_values() works with new distribution format.
Configuration menu - View commit details
-
Copy full SHA for db40888 - Browse repository at this point
Copy the full SHA db40888View commit details -
Revised check_conditions for PerfForesight
Perfect foresight model now produces a conditions_report field in addition to logging. Might need to check on the spacing with logging.
Configuration menu - View commit details
-
Copy full SHA for 9b52e96 - Browse repository at this point
Copy the full SHA 9b52e96View commit details
Commits on Jun 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ce380ae - Browse repository at this point
Copy the full SHA ce380aeView commit details
Commits on Jun 17, 2023
-
Some work on ConsIndShock conditions
Not done yet. Also fixed a couple small mistakes in PF.
Configuration menu - View commit details
-
Copy full SHA for d941c8a - Browse repository at this point
Copy the full SHA d941c8aView commit details
Commits on Jun 20, 2023
-
Finish adding ConsIndShockConditions
Still need to write "verbose" comments for check_conditions.
Configuration menu - View commit details
-
Copy full SHA for 03fb171 - Browse repository at this point
Copy the full SHA 03fb171View commit details
Commits on Jun 21, 2023
-
Still lacks Harmenberg growth patience factor/condition, as well as comments about the Modigliani mortality adjusted GIC. Will look at paper more closely.
Configuration menu - View commit details
-
Copy full SHA for 8836cc3 - Browse repository at this point
Copy the full SHA 8836cc3View commit details
Commits on Jun 23, 2023
-
Add Harmenberg condition, fix small errors
There were a few typos. Violating FVAC but not WRIC now produces an ambiguous message, as the solution only *might* not exist.
Configuration menu - View commit details
-
Copy full SHA for 62c6133 - Browse repository at this point
Copy the full SHA 62c6133View commit details -
Old add_stable_points methods in the PF and IndShock solvers were being run *every* period, which is very costly and essentially pointless. The new method lives on the IndShockConsumerType class and checks for relevant conditions before evaluating. I need to double check, but I think the solution was accelerated significantly by getting rid of that code.
Configuration menu - View commit details
-
Copy full SHA for 4adaf85 - Browse repository at this point
Copy the full SHA 4adaf85View commit details
Commits on Jun 26, 2023
-
Search for mNrmTrg even if GICMod fails. Also put mNrmBal and mNrmTrg into top level. Need to change later. These changes were made while updating the BST dashboard notebook to be compatible.
Configuration menu - View commit details
-
Copy full SHA for ffcccda - Browse repository at this point
Copy the full SHA ffcccdaView commit details
Commits on Jun 28, 2023
-
Add logging, autorun calc_stable_points
The conditions_report is now sent to _log.info if not quiet. ConsIndShock.post_solve will now run calc_stable_points() if appropriate, so that the target and balanced-growth mNrm levels are added to the solution. At the default parameters (infinite horizon), the main branch takes 0.328 seconds to solve on my computer. After moving the calc_stable_points code outside of the solver loop and only running it at the end (if appropriate), it takes 0.100 seconds to solve. Over two-thirds of solution time was being *wasted* on calc_stable_points, whose work is not used during the solution and *could not* plausibly be used.
Configuration menu - View commit details
-
Copy full SHA for 85868b3 - Browse repository at this point
Copy the full SHA 85868b3View commit details
Commits on Jun 29, 2023
-
Revert relocation of calc_stable_points
Per SB's request, I'm splitting the change to calc_stable_points to be in a separate PR. This commit reverts the changes from a prior commit and should make the tests run properly now (because mNrmStE has not been renamed).
Configuration menu - View commit details
-
Copy full SHA for 7c8b421 - Browse repository at this point
Copy the full SHA 7c8b421View commit details
Commits on Jul 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 68825a6 - Browse repository at this point
Copy the full SHA 68825a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 371859c - Browse repository at this point
Copy the full SHA 371859cView commit details
Commits on Jul 27, 2023
-
Patience factors (etc) now in self.auxiliary
A new dictionary has been added to PerfForesightConsumerType and IndShockConsumerType, called auxiliary. It contains all the various patience factors and other semi-useful values that are constructed for check_conditions, but aren't needed to solve (nor simulate) the model. This dictionary can be renamed with a simple replace-all on self.auxiliary.
Configuration menu - View commit details
-
Copy full SHA for e2a46be - Browse repository at this point
Copy the full SHA e2a46beView commit details
Commits on Aug 10, 2023
-
Change name of auxiliary dictionary to bilt
Patient factors and conditions report now life in the bilt dictionary.
Configuration menu - View commit details
-
Copy full SHA for 1af5a0a - Browse repository at this point
Copy the full SHA 1af5a0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2178651 - Browse repository at this point
Copy the full SHA 2178651View commit details
Commits on Sep 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e0183a4 - Browse repository at this point
Copy the full SHA e0183a4View commit details -
Adjust UtilCompPermShk for rho=1
With log utility, the expression for the utility-compensated permanent shock (and thus the value of autarky factor) would break with a divide by zero error. This is now fixed, with the end result that the VAFac is just beta with log utility.
Configuration menu - View commit details
-
Copy full SHA for 2349984 - Browse repository at this point
Copy the full SHA 2349984View commit details