Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check_conditions() #1294

Merged
merged 18 commits into from
Sep 14, 2023
Merged

Update check_conditions() #1294

merged 18 commits into from
Sep 14, 2023

Commits on Jun 15, 2023

  1. Fix ConsIndShockSolver choice and calc_bounding_values

    ConsIndShockSolver is always chosen now, and calc_bounding_values() works with new distribution format.
    mnwhite committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    db40888 View commit details
    Browse the repository at this point in the history
  2. Revised check_conditions for PerfForesight

    Perfect foresight model now produces a conditions_report field in addition to logging. Might need to check on the spacing with logging.
    mnwhite committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    9b52e96 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    ce380ae View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Some work on ConsIndShock conditions

    Not done yet. Also fixed a couple small mistakes in PF.
    mnwhite committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    d941c8a View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Finish adding ConsIndShockConditions

    Still need to write "verbose" comments for check_conditions.
    mnwhite committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    03fb171 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Most verbose comments added

    Still lacks Harmenberg growth patience factor/condition, as well as comments about the Modigliani mortality adjusted GIC. Will look at paper more closely.
    mnwhite committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    8836cc3 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Add Harmenberg condition, fix small errors

    There were a few typos. Violating FVAC but not WRIC now produces an ambiguous message, as the solution only *might* not exist.
    mnwhite committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    62c6133 View commit details
    Browse the repository at this point in the history
  2. Replace add_stable_points

    Old add_stable_points methods in the PF and IndShock solvers were being run *every* period, which is very costly and essentially pointless. The new method lives on the IndShockConsumerType class and checks for relevant conditions before evaluating.
    
    I need to double check, but I think the solution was accelerated significantly by getting rid of that code.
    mnwhite committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    4adaf85 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Small changes

    Search for mNrmTrg even if GICMod fails. Also put mNrmBal and mNrmTrg into top level. Need to change later. These changes were made while updating the BST dashboard notebook to be compatible.
    mnwhite committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    ffcccda View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Add logging, autorun calc_stable_points

    The conditions_report is now sent to _log.info if not quiet. ConsIndShock.post_solve will now run calc_stable_points() if appropriate, so that the target and balanced-growth mNrm levels are added to the solution.
    
    At the default parameters (infinite horizon), the main branch takes 0.328 seconds to solve on my computer. After moving the calc_stable_points code outside of the solver loop and only running it at the end (if appropriate), it takes 0.100 seconds to solve. Over two-thirds of solution time was being *wasted* on calc_stable_points, whose work is not used during the solution and *could not* plausibly be used.
    mnwhite committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    85868b3 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Revert relocation of calc_stable_points

    Per SB's request, I'm splitting the change to calc_stable_points to be in a separate PR. This commit reverts the changes from a prior commit and should make the tests run properly now (because mNrmStE has not been renamed).
    mnwhite committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    7c8b421 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Tiny changes to messages

    mnwhite committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    68825a6 View commit details
    Browse the repository at this point in the history
  2. Missing hyphens, whoops

    mnwhite committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    371859c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Patience factors (etc) now in self.auxiliary

    A new dictionary has been added to PerfForesightConsumerType and IndShockConsumerType, called auxiliary. It contains all the various patience factors and other semi-useful values that are constructed for check_conditions, but aren't needed to solve (nor simulate) the model. This dictionary can be renamed with a simple replace-all on self.auxiliary.
    mnwhite committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    e2a46be View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Change name of auxiliary dictionary to bilt

    Patient factors and conditions report now life in the bilt dictionary.
    mnwhite committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    1af5a0a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2178651 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    e0183a4 View commit details
    Browse the repository at this point in the history
  2. Adjust UtilCompPermShk for rho=1

    With log utility, the expression for the utility-compensated permanent shock (and thus the value of autarky factor) would break with a divide by zero error. This is now fixed, with the end result that the VAFac is just beta with log utility.
    mnwhite committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    2349984 View commit details
    Browse the repository at this point in the history