Update Jacobian code #1298
Update Jacobian code #1298
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1298 +/- ##
==========================================
+ Coverage 72.55% 72.60% +0.04%
==========================================
Files 78 78
Lines 13009 13033 +24
==========================================
+ Hits 9439 9462 +23
- Misses 3570 3571 +1
☔ View full report in Codecov by Sentry. |
|
@alanlujan91 Could you review this? This pull requests fixes an important bug in the HARK methods that compute the Heterogenous Agent Jacobian matrices used in the Sequence Space Jacobian Methods. I'm not sure if I should update the changelog or write an additional test as it is a bug fix. |
|
@Mv77 take a peak? |
| @@ -922,3 +922,7 @@ def test_calc_jacobian(self): | |||
| self.assertAlmostEqual(CJAC_Perm.T[30][29], -0.06120, places=HARK_PRECISION) | |||
| self.assertAlmostEqual(CJAC_Perm.T[30][30], 0.05307, places=HARK_PRECISION) | |||
| self.assertAlmostEqual(CJAC_Perm.T[30][31], 0.04674, places=HARK_PRECISION) | |||
|
|
|||
There was a problem hiding this comment.
Hey,
We should merge this in. It's a bugfix. @wdu9 could you:
- Edit the changelog to reflect the bugfix.
- Resolve the conflict with the jacobian example notebook (merge in master to this and re-run the notebook?)
- Remove some empty lines you introduced in the testfile.
After that I'll merge this in.
Please ensure your pull request adheres to the following guidelines:
This pull request fixes a bug in the calc_jacobian method under the IndShockConsumerType.