Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional Solvers #1395

Merged
merged 23 commits into from
May 2, 2024
Merged

Conversation

alanlujan91
Copy link
Member

This PR contains some suggestions for @mnwhite's ongoing solver overhaul.

Simple functions that can be re-used within a "family" of models, but should not be expected to "jump" out of their own file.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 53.23383% with 188 lines in your changes are missing coverage. Please review.

Project coverage is 70.56%. Comparing base (1d707c7) to head (fb74f68).
Report is 1 commits behind head on master.

Files Patch % Lines
HARK/ConsumptionSaving/ConsPortfolioModel.py 1.81% 162 Missing ⚠️
HARK/ConsumptionSaving/ConsIndShockModel.py 89.02% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
- Coverage   71.72%   70.56%   -1.16%     
==========================================
  Files          84       84              
  Lines       13910    14305     +395     
==========================================
+ Hits         9977    10095     +118     
- Misses       3933     4210     +277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alanlujan91 alanlujan91 changed the title DO NOT MERGE: Functional Solvers WIP: Functional Solvers Mar 27, 2024
@alanlujan91 alanlujan91 mentioned this pull request Apr 10, 2024
3 tasks
@alanlujan91
Copy link
Member Author

@mnwhite updated MPCmaxUnc to apply to MPC_for_interpolation and MPCmaxNow to be the effective mpc max

@alanlujan91 alanlujan91 changed the title WIP: Functional Solvers Functional Solvers May 2, 2024
@alanlujan91 alanlujan91 added the Ready-To-Merge Has been reviewed and when branch is updated and checks pass it should be merged label May 2, 2024
@alanlujan91 alanlujan91 merged commit 228ff34 into econ-ark:master May 2, 2024
15 checks passed
@alanlujan91
Copy link
Member Author

@mnwhite added docstrings and merging as discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-To-Merge Has been reviewed and when branch is updated and checks pass it should be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants