Fix identity function derivatives and remove ancient/dead test code #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There has been an errant asterisk in the arguments of the (trivial) derivative method functions for IdentityFunction for an unknown amount of time. These methods did not work, and apparently were never tested.
For years, the bottom of interpolation.py has had a main() function with test code that I wrote in 2015 or 2016. This code is never used or run, and could not be, as it has many obvious errors in it. This commit deletes that old dead code.
|
It would best if there was an automated test for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in the derivative methods of interpolation.IdentityFunc that has gone undetected for years. It also (finally) deletes hundreds of lines of unused tests that I wrote it in 2015 and early 2016.