-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced os.path
with pathlib
#182
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Not sure if this deserves a release note or any I'll take a look at Windows' fails tomorrow 👍 |
Took a bit longer but I'm getting @econchick Could you approve the workflow? 😄 |
Have been here myself. Getting the paths to work on all platforms and only being able to test thru a gh workflow. Here is a module that is specifically for the challenge this PR is about https://github.com/msftcangoblowm/wreck/blob/master/src/wreck/_safe_path.py If you hit a brick wall or feel going around in circles, this code might be helpful |
Hey, I just made a Pull Request!
Description
Changes all occurrences of
os.path
to usepathlib
instead.Motivation and Context
Closes #179
Have you tested this? If so, how?
Updated unit tests :)
Checklist for PR author(s)
tox -e docs
orinterrogate -c pyproject.toml
(I mean, we should set a good example 😄).README.rst
.README.rst
anddocs/index.rst
for any new/changed CLI flags.versionadded
,versionchanged
, ordeprecated
directives. Find the appropriate next version in the project's__init__.py
file.Release note