Improved recoverability and logging #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgafka
commented
Aug 31, 2024
| $retryStrategy->runCallbackWithRetries(function () use ($message) { | ||
| try { | ||
| $this->insertHandledMessage($message->getPayload(), $message->getHeaders()->headers()); | ||
| }catch (\Exception $exception) { |
There was a problem hiding this comment.
retrying on failure to store in dead letter. If we will manage to store it, there is no need to nack the message in the channel
dgafka
commented
Aug 31, 2024
| $exception | ||
| ); | ||
| } catch (Exception) { | ||
| $connection->close(); |
There was a problem hiding this comment.
If we failed on rollback, it most likely means the connection is already dead, therefore we can close right away.
dgafka
commented
Aug 31, 2024
| } | ||
| if ($amqpAcknowledgementCallback->isAutoAck()) { | ||
| $retryStrategy->runCallbackWithRetries(function () use ($message, $methodInvocation, $logger, $messageChannelName, $amqpAcknowledgementCallback) { | ||
| $amqpAcknowledgementCallback->accept(); |
There was a problem hiding this comment.
We can try to ack with retries, under the hood connection will disconnected when acking fails.
This will help in scenarios like: dbal, redis, sqs channels, however won't help in recovering from AMQP (as same connection is needed for acking).
In case of AMQP, message will be requeued and rehandled again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves recoverabiility for asynchronous scenarios and logging (to provide more info what's happening with Message when it fails)