Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, mbrobbel/rustfmt-check@0.2.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

format

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, mbrobbel/rustfmt-check@0.2.0. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

format

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

format

this expression creates a reference which is immediately dereferenced by the compiler: src/main.rs#L82

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/main.rs:82:37 | 82 | draw_mesh(&mut context, &mesh, rot, default_shader); // Draw all meshes | ^^^^^ help: change this to: `mesh` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: src/main.rs#L42

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/main.rs:42:44 | 42 | match_dimensions(&mut context, &matches)?; | ^^^^^^^^ help: change this to: `matches` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: src/inputs.rs#L115

warning: the borrowed expression implements the required traits --> src/inputs.rs:115:71 | 115 | "stl" => match OpenOptions::new().read(true).open(&path) { | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

the borrowed expression implements the required traits: src/inputs.rs#L108

warning: the borrowed expression implements the required traits --> src/inputs.rs:108:51 | 108 | "obj" => match tobj::load_obj(&path, &tobj::GPU_LOAD_OPTIONS) { | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

this expression creates a reference which is immediately dereferenced by the compiler: src/rasterizer.rs#L44

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/rasterizer.rs:44:32 | 44 | draw_triangle(context, &triangle, transform, &shader); | ^^^^^^^^^ help: change this to: `triangle` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

casting to the same type is unnecessary (`usize` -> `usize`): src/context.rs#L44

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> src/context.rs:44:53 | 44 | ... self.z_buffer = vec![f32::MAX; self.width * self.height as usize]; //f32::MAX is written to the z-buffer as an infinite back-wall t... | ^^^^^^^^^^^^^^^^^^^^ help: try: `self.height` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`usize` -> `usize`): src/context.rs#L38

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> src/context.rs:38:13 | 38 | / if self.image { 39 | | self.width * self.height + self.height 40 | | } else { 41 | | self.width * self.height 42 | | } as usize | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default help: try | 38 ~ if self.image { 39 + self.width * self.height + self.height 40 + } else { 41 + self.width * self.height 42 + } |

this `if` statement can be collapsed: src/main.rs#L62

warning: this `if` statement can be collapsed --> src/main.rs:62:9 | 62 | / if !context.image { 63 | | if poll(target_frame_time - last_time.elapsed())? { 64 | | if let Event::Key(KeyEvent { code, modifiers }) = read()? { 65 | | if code == KeyCode::Char('q') ... | 73 | | } 74 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 62 ~ if !context.image && poll(target_frame_time - last_time.elapsed())? { 63 + if let Event::Key(KeyEvent { code, modifiers }) = read()? { 64 + if code == KeyCode::Char('q') 65 + || (code == KeyCode::Char('c') && (modifiers == KeyModifiers::CONTROL)) 66 + { 67 + stdout.execute(cursor::Show)?; 68 + crossterm::terminal::disable_raw_mode()?; 69 + break; 70 + } 71 + } 72 + } |

unused import: `tobj::LoadOptions`: src/inputs.rs#L7

warning: unused import: `tobj::LoadOptions` --> src/inputs.rs:7:5 | 7 | use tobj::LoadOptions; | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

clippy_check

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

clippy_check

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

clippy_check

build (ubuntu-latest)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions/upload-artifact@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

build (ubuntu-latest)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1, actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

build (ubuntu-latest)

No files were found with the provided path: target/release/rust-sloth. No artifacts will be uploaded.

build (ubuntu-latest)

test

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

test

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

test

build (macOS-latest)

No files were found with the provided path: target/release/rust-sloth. No artifacts will be uploaded.

build (windows-latest)

No files were found with the provided path: target/release/rust-sloth.exe. No artifacts will be uploaded.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update README.md #10

Summary

Update README.md #10

Jobs

Run details

rust.yml

Annotations