Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Updated path for manifest file #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FrittenKeeZ
Copy link

Since the mix-manifest.json file is placed in the theme directory, this will correctly load the asset mappings.

Since the mix-manifest.json file is placed in the theme directory, this will correctly load the asset mappings.
@edcs
Copy link
Owner

edcs commented Aug 16, 2017

Thanks for your contribution 👍

I'm just wondering what your project structure is? Have you moved Statamic above the webroot, as described in the docs here?

https://docs.statamic.com/knowledge-base/running-above-webroot

This is the setup I use, so my mix-manifest.json is located in /public/mix-manifest.json. It sounds like yours is located in /site/themes/theme-name/mix-manifest.json?

I think that if I merged this in then it'd break my websites, but if I leave it unchanged then it doesn't work for you! Perhaps I should change this plugin so that there are some configuration options which let you specify where your manifest file is?

@FrittenKeeZ
Copy link
Author

Yes, Statamic is running above webroot, with my theme located in /public/themes/theme-name, which is also the public path specified in your docs.

My package.json and webpack.mix.js is located in project root, like new Laravel 5.4 sites, and my asset files are located in /site/resources/js and /site/resources/sass.
Using the latest version of Laravel Mix, the mix-manifest.json will be placed in the public path specified in webpack.mix.js.

Can you try and test it with a fresh install?

I'll have a look at some config options when my current project is done, which should be around next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants