add linkup API #295
Open
add linkup API #295
+211
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "depth": depth, | ||
| "output_type": "searchResults", | ||
| } | ||
| return self.client.search(**payload) |
There was a problem hiding this comment.
You can replace this with
return self.client.search({
"query": query,
"depth": depth,
"output_type": "searchResults",
})
| def text__search( | ||
| self, | ||
| query: str, | ||
| depth: str="deep", |
There was a problem hiding this comment.
This should not have a default value.
| } | ||
| return self.client.search(**payload) | ||
| except Exception as e: | ||
| print("DEBUG - Exception occurred:", str(e)) |
There was a problem hiding this comment.
You can probably remove this debug print.
|
|
||
| class LinkupSearch: | ||
|
|
||
|
|
|
|
||
| class LinkupSource: | ||
|
|
||
|
|
| def text__question_answer( | ||
| self, | ||
| query: str, | ||
| depth: str="", |
There was a problem hiding this comment.
Is this default value really necessary?
| "depth": depth, | ||
| "output_type": "sourcedAnswer", | ||
| } | ||
| return self.client.search(**payload) |
There was a problem hiding this comment.
You can replace this with
return self.client.search({
"query": query,
"depth": depth,
"output_type": "sourcedAnswer",
})
| } | ||
| return self.client.search(**payload) | ||
| except Exception as e: | ||
| print("DEBUG - Exception occurred:", str(e)) |
There was a problem hiding this comment.
You can probably remove this debug print.
There was a problem hiding this comment.
Can you rename this file to linkup_answer.py
| from typing import Optional, List | ||
|
|
||
|
|
||
| class LinkupSource: |
There was a problem hiding this comment.
Can you rename this class LinkupAnswer
BruceWouaigne
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.