New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edgee components test cli #202

Merged

CLEMENTINATOR merged 1 commit into feat/cli-component-commands from components-test-cli

Feb 5, 2025

Contributor

CLEMENTINATOR commented Feb 4, 2025

Checklist

I have read the Contributor Guide
I have read and agree to the Code of Conduct
I have added a description of my changes and why I'd like them included in the section below

Description of Changes

First draft of edgee components test
TBD:

wait for settings in manifest
rework the output UX

CLEMENTINATOR requested a review from a team as a code owner

February 4, 2025 16:20

Contributor

alexcasalboni commented Feb 4, 2025

I was just about to write the developer documentation for this ❤️

alexcasalboni reviewed

View reviewed changes

crates/cli/src/commands/components/test.rs Show resolved Hide resolved

alexcasalboni reviewed

View reviewed changes

crates/cli/src/commands/components/test.rs Outdated Show resolved Hide resolved

alexcasalboni reviewed

View reviewed changes

crates/cli/src/commands/components/test.rs Outdated Show resolved Hide resolved

alexcasalboni reviewed

View reviewed changes

crates/cli/src/commands/components/test.rs Outdated Show resolved Hide resolved

alexcasalboni reviewed

View reviewed changes

crates/cli/src/commands/components/test.rs Outdated Show resolved Hide resolved

alexcasalboni reviewed

View reviewed changes

crates/cli/src/commands/components/test.rs Show resolved Hide resolved

alexcasalboni reviewed

View reviewed changes

crates/cli/src/commands/components/test.rs Outdated Show resolved Hide resolved

alexcasalboni reviewed

View reviewed changes

crates/cli/src/commands/components/test.rs Outdated Show resolved Hide resolved

alexcasalboni reviewed

View reviewed changes

crates/cli/src/commands/components/test.rs Outdated Show resolved Hide resolved

alexcasalboni approved these changes

View reviewed changes

Contributor

alexcasalboni left a comment

Great stuff 🚀

I've left a bunch of error message improvements and some high-level comments about things that are still missing (and we can implement in the next PR).

Contributor Author

CLEMENTINATOR commented Feb 5, 2025

I was just about to write the developer documentation for this ❤️

Great stuff 🚀

I've left a bunch of error message improvements and some high-level comments about things that are still missing (and we can implement in the next PR).

than you for the great review, i've fixed most of the stuff !

CLEMENTINATOR force-pushed the components-test-cli branch from c176b6e to 7febc2e Compare

February 5, 2025 06:36

KokaKiwi force-pushed the feat/cli-component-commands branch from 73c413e to dee49cc Compare

February 5, 2025 09:28

CLEMENTINATOR force-pushed the components-test-cli branch from 7febc2e to f36fbad Compare

February 5, 2025 09:41


          components: add test command

dbd5bad

CLEMENTINATOR force-pushed the components-test-cli branch from f36fbad to dbd5bad Compare

February 5, 2025 09:50

CLEMENTINATOR merged commit 709dfe7 into feat/cli-component-commands

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet