-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new and init command #204
feat: add new and init command #204
Conversation
.prompt()?; | ||
|
||
let component_language = Select::new( | ||
"Select the language of the component:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a comment about the future: at some point we will have multiple types of components, so do we expect to have different templates based on language+type or can we just keep 1 boilerplace repo per language that includes all types?
if we go with multiple repos based on language+types, here we will need to select the language/type combo (or maybe an additional step to select the type, and then the language).
If we go for just language selection, this is already OK 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we'd still need to have a subcategory selection for the component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added it following Jill changes to include it in manifest
9e7b7e8
to
58d8bdb
Compare
) | ||
.prompt()?; | ||
|
||
println!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KokaKiwi is there any crates for printing that you might recommand ?
use zip::read::ZipArchive; | ||
|
||
use crate::components::boilerplates::LANGUAGE_OPTIONS; | ||
|
||
#[derive(Debug, clap::Parser)] | ||
pub struct Options {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we would also add optional parameters here so that name and language can be provided as input parameters 👌 (could be in the next PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
8263e47
to
567712f
Compare
Checklist
Description of Changes
Describe your changes here
Related Issues
List related issues here