Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new and init command #204

Merged
merged 10 commits into from
Feb 11, 2025

Conversation

NicolasGirardot
Copy link
Contributor

@NicolasGirardot NicolasGirardot commented Feb 7, 2025

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Describe your changes here

Related Issues

List related issues here

@NicolasGirardot NicolasGirardot requested a review from a team as a code owner February 7, 2025 08:28
.prompt()?;

let component_language = Select::new(
"Select the language of the component:",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment about the future: at some point we will have multiple types of components, so do we expect to have different templates based on language+type or can we just keep 1 boilerplace repo per language that includes all types?

if we go with multiple repos based on language+types, here we will need to select the language/type combo (or maybe an additional step to select the type, and then the language).

If we go for just language selection, this is already OK 👌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'd still need to have a subcategory selection for the component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added it following Jill changes to include it in manifest

crates/cli/Cargo.toml Outdated Show resolved Hide resolved
)
.prompt()?;

println!(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KokaKiwi is there any crates for printing that you might recommand ?

use zip::read::ZipArchive;

use crate::components::boilerplates::LANGUAGE_OPTIONS;

#[derive(Debug, clap::Parser)]
pub struct Options {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we would also add optional parameters here so that name and language can be provided as input parameters 👌 (could be in the next PR)

Copy link
Contributor

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@NicolasGirardot NicolasGirardot merged commit 2b1910d into feat/cli-component-commands Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants