Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform: only set confidential_instance_type if cc_technology is SEV_SNP #3085

Merged
merged 1 commit into from
May 14, 2024

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented May 13, 2024

Context

Upgrades of existing GCP SEV-ES clusters are failing because setting confidential_instance_type makes Terraform want to re-create the instance templates, which does not work because they are still in use by instances.

Proposed change(s)

  • Only set confidential_instance_type if cc_technology is SEV_SNP
    • When this feature is introduced into the mainline GCP Terraform provider, we will likely have to introduce some form of migration, but I would hold of on that until the provider maintainers decide on how this will look like

Related issue

Checklist

@daniel-weisse daniel-weisse added the no changelog Change won't be listed in release changelog label May 13, 2024
Copy link

netlify bot commented May 13, 2024

Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 87c3f36
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/66434d0addcec300089b812d

@daniel-weisse daniel-weisse force-pushed the fix/terraform/gcp-sev-es branch 3 times, most recently from 0db8983 to 7b07f1d Compare May 14, 2024 07:20
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse marked this pull request as ready for review May 14, 2024 13:14
@daniel-weisse daniel-weisse requested a review from msanft May 14, 2024 13:14
@daniel-weisse daniel-weisse merged commit 8219005 into main May 14, 2024
11 checks passed
@daniel-weisse daniel-weisse deleted the fix/terraform/gcp-sev-es branch May 14, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants