mount: merge mounting code #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
from
f28e6c8 to
957cc7f
Compare
jmxnzo
force-pushed
the
internal/mount-refactoring-jla
branch
from
38e81f2 to
c0ba201
Compare
jmxnzo
force-pushed
the
initializer/cryptsetup-integration-jla
branch
3 times, most recently
from
1bbc7e2 to
a6c11ec
Compare
jmxnzo
force-pushed
the
internal/mount-refactoring-jla
branch
from
c0ba201 to
fce3c71
Compare
jmxnzo
changed the base branch from
initializer/cryptsetup-integration-jla
to
main
|
burgerdev
reviewed
Jan 21, 2025
jmxnzo
force-pushed
the
internal/mount-refactoring-jla
branch
3 times, most recently
from
134dcd7 to
c728ff7
Compare
burgerdev
reviewed
Jan 21, 2025
jmxnzo
force-pushed
the
internal/mount-refactoring-jla
branch
from
c607234 to
1fd8541
Compare
burgerdev
approved these changes
Jan 22, 2025
|
Remember to squash, and please drop the leading |
jmxnzo
force-pushed
the
internal/mount-refactoring-jla
branch
2 times, most recently
from
0ca6bdf to
bf41aa8
Compare
jmxnzo
changed the title
jmxnzo
force-pushed
the
internal/mount-refactoring-jla
branch
from
bf41aa8 to
f752f49
Compare
jmxnzo
added
no changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the shared code of mounting logic between the coordinator and initializer after #1153 to internal/mount. In addition it adds some more documentation to mount.go and unit testing for the blkid parsing logic.