rfc: add secure pv injection rfc #1204
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgerdev
reviewed
Feb 3, 2025
rfc/009-secure-pv-injection.md
Outdated
Comment on lines
55
to
56
| - A PVC with the name `state` will be added to the resource with size specified | ||
| by `contrast.edgeless.systems/secure-pv-size` or 1Gi by default. |
There was a problem hiding this comment.
This only works for resources that support VolumeClaimTemplates (i.e. StatefulSet), right? I think we should also support a simple pod with a pre-existing pvc, or a DaemonSet with a hostPath device. So I'd say we should assume existence of a volume with a given name and work from there. The name of the emptyDir should probably stay an input, so the annotation should go something like
contrast.edgeless.systems/secure-pv: "my-volume-name:my-volume-mount-name"This format would also allow straightforward extension to
rfc/009-secure-pv-injection.md
Outdated
Comment on lines
79
to
82
| With this change, there is no longer any need for the `cryptsetup` subcommand to | ||
| be specified through the `cobra` library, as everything now happens in one | ||
| container. The `cryptsetup` subcommand can be removed and replaced by internal | ||
| decision making in the Initializer. |
There was a problem hiding this comment.
What if the automatic cryptsetup does not work for my use-case and I'd like to use the initializer as a separate init container as documented today?
davidweisse
force-pushed
the
dav/rfc-cryptsetup-injection
branch
from
f104bd7 to
00dc969
Compare
davidweisse
force-pushed
the
dav/rfc-cryptsetup-injection
branch
from
00dc969 to
a1f7226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.