Wrong label-filter values with alt-Names #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sorting objects by label, get the values for the label-filter properties not based on the position of the object label but on its value.
Update function order-items
|
(in the first commit I made a wrong change, fixed it in third commit "Update function edwebapi:order-items") |
jannikFranz
force-pushed
the
master
branch
2 times, most recently
from
61fcd85 to
9e95eee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sorting objects by label, get the values for the label-filter properties not based on the position of the object label but on its string value.
A person entry has a regular name "Leibowitz, Ellen" and an alternative name "Adler, Ellen".
In the entry for "Adler, Ellen" inside the model, the alphabet filter property has the wrong value "L" (and vice versa for "Leibowitz, Ellen") because the property is created based on the "label-filter" map and the position of the label in the "labels" array. "Adler, Ellen" is second position in the "labels" array, in the "label-filter" properties however, the key on second position holds the values for "Leibowitz, Ellen". Instead of getting the values based on their position in the "labels" array, get them based on their key, which holds the label.