Skip to content

Conversation

@pascalsaussier-edifice
Copy link

Description

  • Updates Storybook from v8 to v9.
  • Updates "@chromatic-com/storybook": "^4.1.3",
  • Updates "eslint-plugin-storybook": "9.1.17",
  • Updates @pixi/react from packages/react to 8.0.5,
  • Updates pixi.js from packages/react to 8.15.0,
  • Updates ImageEditor component to use latest pixi version
  • Lint Css for packages/bootstrap/src/components/_media-library.scss file (replacement of rgba function)

Which Package changed?

Please check the name of the package you changed

  • Components
  • Core
  • Icons
  • Hooks

Has the documentation changed?

  • Storybook

Type of change

Please check options that are relevant.

  • Chore (PATCH)
  • Doc (PATCH)
  • Bug fix (PATCH)
  • New feature (MINOR)
  • Breaking change (MAJOR)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades Storybook from v8 to v9, updates related dependencies, and makes necessary code changes to support the new version. The upgrade includes updating import paths from @storybook/blocks to @storybook/addon-docs/blocks, changing @storybook/react imports to @storybook/react-vite, and updating the PixiJS library and its React bindings in the ImageEditor component.

Changes:

  • Storybook upgraded from v8.4.5 to v9.1.17 across all related packages
  • Import paths updated for Storybook v9 compatibility throughout story files and MDX documentation
  • PixiJS and @pixi/react updated to v8.x with corresponding API changes in ImageEditor component

Reviewed changes

Copilot reviewed 164 out of 165 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Updates Storybook core and addon packages to v9.1.17
packages/react/package.json Updates @pixi/react to 8.0.5 and pixi.js to 8.15.0
apps/docs/.storybook/main.ts Simplifies addon configuration and updates path resolution for v9
apps/docs/.storybook/manager.ts Changes import from @storybook/manager-api to storybook/manager-api
apps/docs/.storybook/theme.ts Updates theming import path for v9
apps/docs/.storybook/preview.tsx Changes import from @storybook/react to @storybook/react-vite
packages/react/src/modules/multimedia/ImageEditor/components/ImageEditor.tsx Updates PixiJS component from Stage to Application with new API
packages/react/src/hooks/useBrowserInfo/useBrowserInfo.ts Changes UAParser import to named export
packages/react/src/modules/modals/ResourceModal/ResourceModal.tsx Adds fallback to document.body for portal element
All .stories.tsx files Updates imports from @storybook/react to @storybook/react-vite
All .mdx files Updates imports from @storybook/blocks to @storybook/addon-docs/blocks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +36 to +37
dirname(fileURLToPath(import.meta.url)),
'../node_modules/@edifice.io/bootstrap/dist/images',
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded relative path '../node_modules/@edifice.io/bootstrap/dist/images' is fragile and could break if the directory structure changes. Consider using a more robust path resolution approach, such as resolving from the project root or using a constant defined at the top of the file.

Copilot uses AI. Check for mistakes.
/>
</Modal>,
document.getElementById('portal') as HTMLElement,
(document.getElementById('portal') as HTMLElement) || document.body,
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fallback to document.body when 'portal' element is not found could lead to unexpected layout issues. Consider adding a comment explaining when this fallback occurs and whether this is an expected scenario, or validate that the portal element exists earlier in the component lifecycle.

Copilot uses AI. Check for mistakes.
@david-cc david-cc self-requested a review January 9, 2026 17:23
Copy link
Member

@david-cc david-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faudra remonter à la team QA de tester le composant ImageEditor pour s’assurer que y’a pas de régression suite à cette montée de version, sinon OK pour moi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants