-
Notifications
You must be signed in to change notification settings - Fork 4
[Draft]refactor(storybook) update storybook to v9 #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades Storybook from v8 to v9, updates related dependencies, and makes necessary code changes to support the new version. The upgrade includes updating import paths from @storybook/blocks to @storybook/addon-docs/blocks, changing @storybook/react imports to @storybook/react-vite, and updating the PixiJS library and its React bindings in the ImageEditor component.
Changes:
- Storybook upgraded from v8.4.5 to v9.1.17 across all related packages
- Import paths updated for Storybook v9 compatibility throughout story files and MDX documentation
- PixiJS and @pixi/react updated to v8.x with corresponding API changes in ImageEditor component
Reviewed changes
Copilot reviewed 164 out of 165 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates Storybook core and addon packages to v9.1.17 |
| packages/react/package.json | Updates @pixi/react to 8.0.5 and pixi.js to 8.15.0 |
| apps/docs/.storybook/main.ts | Simplifies addon configuration and updates path resolution for v9 |
| apps/docs/.storybook/manager.ts | Changes import from @storybook/manager-api to storybook/manager-api |
| apps/docs/.storybook/theme.ts | Updates theming import path for v9 |
| apps/docs/.storybook/preview.tsx | Changes import from @storybook/react to @storybook/react-vite |
| packages/react/src/modules/multimedia/ImageEditor/components/ImageEditor.tsx | Updates PixiJS component from Stage to Application with new API |
| packages/react/src/hooks/useBrowserInfo/useBrowserInfo.ts | Changes UAParser import to named export |
| packages/react/src/modules/modals/ResourceModal/ResourceModal.tsx | Adds fallback to document.body for portal element |
| All .stories.tsx files | Updates imports from @storybook/react to @storybook/react-vite |
| All .mdx files | Updates imports from @storybook/blocks to @storybook/addon-docs/blocks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dirname(fileURLToPath(import.meta.url)), | ||
| '../node_modules/@edifice.io/bootstrap/dist/images', |
Copilot
AI
Jan 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded relative path '../node_modules/@edifice.io/bootstrap/dist/images' is fragile and could break if the directory structure changes. Consider using a more robust path resolution approach, such as resolving from the project root or using a constant defined at the top of the file.
| /> | ||
| </Modal>, | ||
| document.getElementById('portal') as HTMLElement, | ||
| (document.getElementById('portal') as HTMLElement) || document.body, |
Copilot
AI
Jan 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fallback to document.body when 'portal' element is not found could lead to unexpected layout issues. Consider adding a comment explaining when this fallback occurs and whether this is an expected scenario, or validate that the portal element exists earlier in the component lifecycle.
david-cc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faudra remonter à la team QA de tester le composant ImageEditor pour s’assurer que y’a pas de régression suite à cette montée de version, sinon OK pour moi !
6d036f1 to
c40319e
Compare
b2c3329 to
ab43d2f
Compare
c40319e to
67c1332
Compare
67c1332 to
e81086b
Compare
Description
@pixi/reactfrompackages/reactto 8.0.5,pixi.jsfrompackages/reactto 8.15.0,ImageEditorcomponent to use latest pixi versionpackages/bootstrap/src/components/_media-library.scssfile (replacement of rgba function)Which Package changed?
Please check the name of the package you changed
Has the documentation changed?
Type of change
Please check options that are relevant.
Checklist: