-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DocumentModel initialization #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Mutation testing passedReport: https://dashboard.stryker-mutator.io/reports/github.com/editor-js/document-model/PR-39 Mutated filessrc/entities/BlockNode/consts.ts |
Coverage report
Show new covered files 🐣
Test suite run success310 tests passing in 17 suites. Report generated by 🧪jest coverage report action from 91b40ee |
ilyamore88
reviewed
Oct 8, 2023
Could you please write a short changelog in the PR description? It helps with review |
neSpecc
reviewed
Oct 17, 2023
neSpecc
reviewed
Nov 2, 2023
Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
neSpecc
approved these changes
Nov 3, 2023
ilyamore88
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
$t
initialize
methods to EditorDocument and BlockNode classes to create entities from passed serialized dataTwo issues raised to cover some of added code with integration tests: #40 #41