Skip to content

Fix: add check to disallow social user password reset. #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop-koa
Choose a base branch
from
Open

Fix: add check to disallow social user password reset. #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions openedx/core/djangoapps/user_authn/views/password_reset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,16 @@ def password_reset(request):
Attempts to send a password reset e-mail.
"""
user = request.user
profile = EdlyUserProfile.objects.filter(user=user).first()
if profile and profile.is_social_user:
return JsonResponse(
{
'success': False,
'value': _("This account uses social login; password reset isn't available.")
},
status=400
)

# Prefer logged-in user's email
email = user.email if user.is_authenticated else request.POST.get('email')
AUDIT_LOG.info("Password reset initiated for email %s.", email)
Expand Down