Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build under MSYS2 MinGW-w64 (Windows) #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

c72578
Copy link

@c72578 c72578 commented Dec 8, 2019

  • Under MSYS2 MinGW-w64 the filename of the hidapi import library
    is "libhidapi.dll.a". Add hidapi.dll to NAMES of findlibrary().

added quotation marks to prevent error:
Regular expression "(-libusb|/libusb/" cannot compile
@c72578 c72578 force-pushed the 2019-12-08_Fix_build_under_msys2_mingw-w64 branch from 3152047 to bf0efe0 Compare December 8, 2019 20:06
@c72578 c72578 force-pushed the 2019-12-08_Fix_build_under_msys2_mingw-w64 branch from bf0efe0 to 23c6aec Compare December 9, 2019 07:44
- Under MSYS2 MinGW-w64 the filename of the hidapi import library
  is "libhidapi.dll.a". Add hidapi.dll to NAMES of findlibrary().
@c72578 c72578 force-pushed the 2019-12-08_Fix_build_under_msys2_mingw-w64 branch from 23c6aec to b85f959 Compare December 9, 2019 15:29
@c72578
Copy link
Author

c72578 commented Dec 9, 2019

Here are some short instructions for building TEMPERed for Windows under MSYS2 MinGW-w64:

# install the required packages cmake and hidapi:
pacman -Sy --needed ${MINGW_PACKAGE_PREFIX}-cmake ${MINGW_PACKAGE_PREFIX}-hidapi

# Run the following commands from the base of the TEMPERed directory:
mkdir build
cd build
${MINGW_PREFIX}/bin/cmake.exe -G "MSYS Makefiles" ..
make
cd ..

@c72578
Copy link
Author

c72578 commented Dec 9, 2019

Just in case somebody is looking for Windows binaries of TEMPered, builds have been prepared and added here for download:
https://github.com/c72578/TEMPered/releases

The builds include PRs from here, which added new devices:
0C45:7402 TEMPerHumM12V1.2
0C45:7402 TEMPerHumM12V1.3
413d:2107 TEMPer2V3.1 or TEMPer2V3.3 (TEMPerGold_V3.1, TEMPerX_V3.3)

@mwerezak
Copy link

@c72578 I think this repo is dead. If you target your PR to https://github.com/mwerezak/TEMPered I will try to merge it.

@mwerezak
Copy link

Actually I was able to do it myself 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants