-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds FilterTenantAwareLinksFromStudio in filters pipeline #219
base: master
Are you sure you want to change the base?
Conversation
4261fa5
to
d91dc83
Compare
d91dc83
to
a9212d3
Compare
7963cbf
to
2f04adb
Compare
@mariajgrimaldi about your comment #219 (comment) Don't you think the name should be FilterOrgAwareLMSURLStudio instead of just OrgAwareLMSURLStudio? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good enough, thank you. Please, remember to add a new entry to the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve once tests pass. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! @jignaciopm, remember to update the requirements so the latest openedx-filters version is used during tests (although new definitions are not used, I think it's still important to do so). Let me know!
f224615
to
2b82024
Compare
2b82024
to
838804d
Compare
Description
This PR adds a custom filter pipeline to get LMS_ROOT_URL value for org from tenant site.
The idea is including some changes in openedx-filters and edx-platform repositories to anyone implement the filter function, and one clear example to use is this custom pipeline on eox-tenant plugin.
Dependencies:
Testing instructions
Install the plugin with the changes in openedx/edx-platform and openedx/openedx-filters branches. Use the Tutor instructions to install the eox-tenant django plugin with the changes in this branch.
Create a Tenant and import a certificate course (You need to create a tenant for Studio too). Go on to create sites: http://local.edly.io:8000/admin/eox_tenant/tenantconfig/
Add the following configurations to your configuration site and Studio tenant.
or too you can add settings in
/env/apps/openedx/settings/cms/development.py
Go to Settings-> Schedule & Details, click on the “Course Summary Page” link, which should direct you to the URL of the specific tenant
Verify that the link of the "Invite your students" button in the body refers to the URL of the specific tenant
Also check for a link to a course summary below the “course overview” text box.
Go to Content -> Files & uploads, verify the absolute links of any asset (In the Web button), which should lead to the URL of the specific tenant
Example Tenant Config
Additional information
Checklist for Merge