Minor changes to RuleWithActions::executeTransformation

- Make it private as it's only called by
  RuleWithActions::executeTransformations

headers/modsecurity/rule_with_actions.h

@@ -121,15 +121,6 @@ class RuleWithActions : public Rule {
     void executeTransformations(
         Transaction *trasn, const std::string &value, TransformationResults &ret);
 
-    inline void executeTransformation(
-        actions::transformations::Transformation *a,
-        std::shared_ptr<std::string> *value,
-        Transaction *trans,
-        TransformationResults *ret,
-        std::string *path,
-        int *nth) const;
-
-
     void performLogging(Transaction *trans,
         std::shared_ptr<RuleMessage> ruleMessage,
         bool lastLog = true,
@@ -166,6 +157,14 @@ class RuleWithActions : public Rule {
     RuleWithActions *m_chainedRuleParent;
 
  private:
+    inline void executeTransformation(
+        actions::transformations::Transformation *a,
+        std::shared_ptr<std::string> *value,
+        Transaction *trans,
+        TransformationResults *ret,
+        std::string *path,
+        int *nth) const;
+
     /* actions */
     actions::Action *m_disruptiveAction;
     actions::LogData *m_logData;

src/rule_with_actions.cc

@@ -326,10 +326,10 @@ inline void RuleWithActions::executeTransformation(
     std::string *path,
     int *nth) const {
 
-    std::string *oldValue = (*value).get();
-    std::string newValue = a->evaluate(*oldValue, trans);
+    const auto &oldValue = *value->get();
+    const auto newValue = a->evaluate(oldValue, trans);
 
-    if (newValue != *oldValue) {
+    if (newValue != oldValue) {
         auto u = std::make_shared<std::string>(newValue);
         if (m_containsMultiMatchAction) {
             ret->push_back({u, a->m_name});