Skip to content

Commit

Permalink
Add "redrive_policy" in queue config
Browse files Browse the repository at this point in the history
  • Loading branch information
eduardoklosowski committed Sep 5, 2024
1 parent f0df5ac commit 067b1e2
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 4 deletions.
10 changes: 8 additions & 2 deletions src/qldebugger/config/file_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from typing import Any, BinaryIO, Dict, List, NamedTuple, Optional, Tuple, Union

import tomli
from pydantic import BaseModel, Field, field_validator
from pydantic import BaseModel, Field, PositiveInt, field_validator


class ConfigAWS(BaseModel):
Expand Down Expand Up @@ -44,7 +44,13 @@ class ConfigTopic(BaseModel):
subscribers: List[ConfigTopicSubscriber] = Field(default_factory=list)


class ConfigQueue(BaseModel): ...
class ConfigQueueRedrivePolicy(BaseModel):
dead_letter_queue: str
max_receive_count: PositiveInt


class ConfigQueue(BaseModel):
redrive_policy: Optional[ConfigQueueRedrivePolicy] = None


class NameHandlerTuple(NamedTuple):
Expand Down
19 changes: 17 additions & 2 deletions tests/qldebugger/config/test_file_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
ConfigEventSourceMapping,
ConfigLambda,
ConfigQueue,
ConfigQueueRedrivePolicy,
ConfigSecretBinary,
ConfigSecretString,
ConfigTopic,
Expand Down Expand Up @@ -71,11 +72,25 @@ def test_default_values(self) -> None:
}


class TestConfigQueueRedrivePolicy:
def test_required_fields(self) -> None:
required_fields = ['dead_letter_queue', 'max_receive_count']

with pytest.raises(ValidationError) as exc_info:
ConfigQueueRedrivePolicy.model_validate({})

assert {error['loc'] for error in exc_info.value.errors() if error['type'] == 'missing'} == {
(field,) for field in required_fields
}


class TestConfigQueue:
def test_empty_object(self) -> None:
def test_default_values(self) -> None:
returned = ConfigQueue()

assert returned.model_dump() == {}
assert returned.model_dump() == {
'redrive_policy': None,
}


class TestNameHandlerTuple:
Expand Down

0 comments on commit 067b1e2

Please sign in to comment.