Skip to content

Commit

Permalink
Mark static Queue<IParsedLine> ParseFile() as obsolete (#164)
Browse files Browse the repository at this point in the history
  • Loading branch information
eduherminio authored Dec 2, 2023
1 parent f52e271 commit 6a3b2aa
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/FileParser/Implementations/ParsedFile.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ public ParsedFile(string path, char[] existingSeparator)
/// <param name="path">FilePath</param>
/// <param name="existingSeparator">Word separator (space by default)</param>
public ParsedFile(string path, string? existingSeparator = null)
#pragma warning disable CS0618 // Type or member is obsolete - will keep it as private
: base(ParseFile(path, existingSeparator))
#pragma warning restore CS0618 // Type or member is obsolete
{
}

Expand Down Expand Up @@ -211,6 +213,7 @@ public static List<List<T>> ReadAllGroupsOfLines<T>(string path)
/// <exception cref="ArgumentException"></exception>
/// <exception cref="ArgumentNullException"></exception>
/// <returns></returns>
[Obsolete("This method exposes internal functionality and was made public accidentally. It will be removed in next major release, please used ParsedFile constructor instead.")]

Check warning on line 216 in src/FileParser/Implementations/ParsedFile.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

Do not forget to remove this deprecated code someday. (https://rules.sonarsource.com/csharp/RSPEC-1133)
public static Queue<IParsedLine> ParseFile(string path, string? existingSeparator = null)
{
Queue<IParsedLine> parsedFile = new();
Expand Down

0 comments on commit 6a3b2aa

Please sign in to comment.