Skip to content

Continuation of "Add dotnet 8 support" #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2024
Merged

Continuation of "Add dotnet 8 support" #870

merged 1 commit into from
Mar 3, 2024

Conversation

edumserrano
Copy link
Owner

@edumserrano edumserrano commented Mar 3, 2024 •
edited
Loading

Continuation of #804. Was missing:

  • run tests in .net8 target framework
  • use .net8 code coverage results instead of .net7

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024

Test runs on ubuntu-latest for commit 62424a3

✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v6.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 145

Date: 2024-03-03 10:24:56 - 2024-03-03 10:25:00
Run Duration: 3s 656ms

GitHub Runner OS: ubuntu-latest
Operating System: Ubuntu 22.04.4 LTS
Framework: .NETCoreApp,Version=v6.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
145 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 6.0.27) [xUnit.net 00:00:00.27]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.81]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.81]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.64]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v6.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 150

Date: 2024-03-03 10:25:00 - 2024-03-03 10:25:10
Run Duration: 9s 776ms

GitHub Runner OS: ubuntu-latest
Operating System: Ubuntu 22.04.4 LTS
Framework: .NETCoreApp,Version=v6.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
150 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 6.0.27) [xUnit.net 00:00:00.11]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.23]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.23]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:09.26]   Finished:    DotNet.Sdk.Extensions.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v7.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 145

Date: 2024-03-03 10:25:12 - 2024-03-03 10:25:18
Run Duration: 5s 354ms

GitHub Runner OS: ubuntu-latest
Operating System: Ubuntu 22.04.4 LTS
Framework: .NETCoreApp,Version=v7.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
145 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 7.0.16) [xUnit.net 00:00:00.33]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.87]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.87]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.40]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v7.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 150

Date: 2024-03-03 10:25:18 - 2024-03-03 10:25:28
Run Duration: 9s 642ms

GitHub Runner OS: ubuntu-latest
Operating System: Ubuntu 22.04.4 LTS
Framework: .NETCoreApp,Version=v7.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
150 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 7.0.16) [xUnit.net 00:00:00.10]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.21]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.21]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:09.15]   Finished:    DotNet.Sdk.Extensions.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v8.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 145

Date: 2024-03-03 10:25:30 - 2024-03-03 10:25:33
Run Duration: 2s 597ms

GitHub Runner OS: ubuntu-latest
Operating System: Ubuntu 22.04.4 LTS
Framework: .NETCoreApp,Version=v8.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
145 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 8.0.2) [xUnit.net 00:00:00.22]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.67]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.67]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.12]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v8.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 150

Date: 2024-03-03 10:25:33 - 2024-03-03 10:25:43
Run Duration: 9s 497ms

GitHub Runner OS: ubuntu-latest
Operating System: Ubuntu 22.04.4 LTS
Framework: .NETCoreApp,Version=v8.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
150 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 8.0.2) [xUnit.net 00:00:00.08]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.17]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.17]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:09.06]   Finished:    DotNet.Sdk.Extensions.Tests
----

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024

Test runs on windows-latest for commit 62424a3

✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v6.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 145

Date: 2024-03-03 10:27:03 - 2024-03-03 10:27:21
Run Duration: 17s 831ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v6.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
145 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 6.0.27) [xUnit.net 00:00:01.22]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:04.15]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:04.15]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:09.23]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v6.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 150

Date: 2024-03-03 10:27:22 - 2024-03-03 10:27:32
Run Duration: 10s 130ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v6.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
150 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 6.0.27) [xUnit.net 00:00:00.16]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.25]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.25]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:09.57]   Finished:    DotNet.Sdk.Extensions.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v7.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 145

Date: 2024-03-03 10:27:35 - 2024-03-03 10:27:50
Run Duration: 14s 833ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v7.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
145 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 7.0.16) [xUnit.net 00:00:01.25]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:03.03]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:03.04]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:06.79]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v7.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 150

Date: 2024-03-03 10:27:50 - 2024-03-03 10:28:00
Run Duration: 10s 53ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v7.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
150 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 7.0.16) [xUnit.net 00:00:00.16]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.23]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.24]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:09.54]   Finished:    DotNet.Sdk.Extensions.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v8.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 145

Date: 2024-03-03 10:28:03 - 2024-03-03 10:28:10
Run Duration: 7s 384ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v8.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
145 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 8.0.2) [xUnit.net 00:00:00.63]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.78]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.78]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:06.73]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v8.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 150

Date: 2024-03-03 10:28:11 - 2024-03-03 10:28:21
Run Duration: 10s 3ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v8.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
150 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.7+8f2703126a (64-bit .NET 8.0.2) [xUnit.net 00:00:00.13]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.20]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.20]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:09.55]   Finished:    DotNet.Sdk.Extensions.Tests
----

@codecov Codecov
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (85ffbaa) to head (62424a3).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          76       76           
  Lines        1294     1294           
  Branches      118      118           
=======================================
  Hits         1223     1223           
  Misses         44       44           
  Partials       27       27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edumserrano edumserrano merged commit 042b6bd into main Mar 3, 2024
@edumserrano edumserrano deleted the net8-pipelines branch March 3, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edumserrano