Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add portal-designer to devstack #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huniafatima-arbi
Copy link
Member

No description provided.

@huniafatima-arbi huniafatima-arbi self-assigned this Nov 19, 2024
@huniafatima-arbi huniafatima-arbi marked this pull request as draft November 19, 2024 11:48
@huniafatima-arbi huniafatima-arbi changed the title chore: add docker compose service and shell target chore: add portal-designer to devstack Nov 19, 2024
@huniafatima-arbi huniafatima-arbi marked this pull request as ready for review November 19, 2024 19:24
@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/add-portal-designer-in-devstack branch from 8c43dbf to 173e049 Compare November 20, 2024 09:23
@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/add-portal-designer-in-devstack branch 2 times, most recently from ae060a1 to 66d544a Compare February 7, 2025 10:07
Copy link
Member

@iamsobanjaved iamsobanjaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the change in docker-compose.yml file. Also indicated few other possible changes.

Makefile Outdated Show resolved Hide resolved
docker-compose-host.yml Outdated Show resolved Hide resolved
docker-compose-host.yml Outdated Show resolved Hide resolved
provision-designer.sh Outdated Show resolved Hide resolved
provision-designer.sh Outdated Show resolved Hide resolved
provision-designer.sh Outdated Show resolved Hide resolved
docs/service_list.rst Outdated Show resolved Hide resolved
@huniafatima-arbi
Copy link
Member Author

@iamsobanjaved all the feedback incorporated. Please review

@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/add-portal-designer-in-devstack branch from 3057e37 to 5b139f5 Compare February 10, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants