generated from eea/volto-addon-template
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #276 from eea/develop
Release
- Loading branch information
Showing
10 changed files
with
289 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,7 +54,7 @@ const defaultConfig = { | |
| allowReferrer: true, | ||
| }, | ||
| ], | ||
| } | ||
| }, | ||
| }; | ||
|
|
||
| const config = addonExtenders.reduce( | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
102 changes: 102 additions & 0 deletions
102
src/customizations/volto/components/manage/Widgets/NumberWidget.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| /** | ||
| * NumberWidget component. | ||
| * @module components/manage/Widgets/PassswordWidget | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import { Input } from 'semantic-ui-react'; | ||
| import { FormFieldWrapper } from '@plone/volto/components'; | ||
| import { injectIntl } from 'react-intl'; | ||
|
|
||
| /** | ||
| * NumberWidget component class. | ||
| * | ||
| * To use it, in schema properties, declare a field like: | ||
| * | ||
| * ```jsx | ||
| * { | ||
| * title: "Number", | ||
| * type: 'number', | ||
| * } | ||
| * ``` | ||
| */ | ||
| const NumberWidget = (props) => { | ||
| const { | ||
| id, | ||
| value, | ||
| onChange, | ||
| onBlur, | ||
| onClick, | ||
| isDisabled, | ||
| maximum, | ||
| minimum, | ||
| placeholder, | ||
| step, | ||
| } = props; | ||
| return ( | ||
| <FormFieldWrapper {...props}> | ||
| <Input | ||
| id={`field-${id}`} | ||
| name={id} | ||
| type="number" | ||
| disabled={isDisabled} | ||
| min={minimum || null} | ||
| max={maximum || null} | ||
| step={step} | ||
| value={value ?? ''} | ||
| placeholder={placeholder} | ||
| onChange={({ target }) => | ||
| onChange( | ||
| id, | ||
| target.value === '' ? undefined : window.parseInt(target.value), | ||
| ) | ||
| } | ||
| onBlur={({ target }) => | ||
| onBlur( | ||
| id, | ||
| target.value === '' ? undefined : window.parseInt(target.value), | ||
| ) | ||
| } | ||
| onClick={() => onClick()} | ||
| /> | ||
| </FormFieldWrapper> | ||
| ); | ||
| }; | ||
|
|
||
| /** | ||
| * Property types. | ||
| * @property {Object} propTypes Property types. | ||
| * @static | ||
| */ | ||
| NumberWidget.propTypes = { | ||
| id: PropTypes.string.isRequired, | ||
| title: PropTypes.string.isRequired, | ||
| description: PropTypes.oneOfType([PropTypes.string, PropTypes.object]), | ||
| required: PropTypes.bool, | ||
| error: PropTypes.arrayOf(PropTypes.string), | ||
| value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]), | ||
| onChange: PropTypes.func.isRequired, | ||
| wrapped: PropTypes.bool, | ||
| maximum: PropTypes.number, | ||
| minimum: PropTypes.number, | ||
| step: PropTypes.number, | ||
| placeholder: PropTypes.string, | ||
| }; | ||
|
|
||
| /** | ||
| * Default properties. | ||
| * @property {Object} defaultProps Default properties. | ||
| * @static | ||
| */ | ||
| NumberWidget.defaultProps = { | ||
| description: null, | ||
| required: false, | ||
| error: [], | ||
| value: null, | ||
| onChange: () => {}, | ||
| onBlur: () => {}, | ||
| onClick: () => {}, | ||
| }; | ||
|
|
||
| export default injectIntl(NumberWidget); |
120 changes: 120 additions & 0 deletions
120
src/customizations/volto/components/manage/Widgets/NumberWidget.test.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| import React from 'react'; | ||
| import { render, screen, fireEvent } from '@testing-library/react'; | ||
| import { Provider } from 'react-intl-redux'; | ||
| import configureStore from 'redux-mock-store'; | ||
| import '@testing-library/jest-dom/extend-expect'; | ||
|
|
||
| import NumberWidget from './NumberWidget'; | ||
|
|
||
| const mockStore = configureStore(); | ||
|
|
||
| const store = mockStore({ | ||
| intl: { | ||
| locale: 'en', | ||
| messages: {}, | ||
| }, | ||
| }); | ||
|
|
||
| describe('NumberWidget', () => { | ||
| it('renders a number widget component', () => { | ||
| const onChange = jest.fn(); | ||
| render( | ||
| <Provider store={store}> | ||
| <NumberWidget | ||
| id="my-field" | ||
| title="My field" | ||
| fieldSet="default" | ||
| onChange={onChange} | ||
| /> | ||
| </Provider>, | ||
| ); | ||
|
|
||
| expect(screen.getByRole('spinbutton')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| describe('onChange behavior', () => { | ||
| it('converts string value to number on change', () => { | ||
| const onChange = jest.fn(); | ||
| render( | ||
| <Provider store={store}> | ||
| <NumberWidget id="my-field" title="My field" onChange={onChange} /> | ||
| </Provider>, | ||
| ); | ||
|
|
||
| const input = screen.getByRole('spinbutton'); | ||
| fireEvent.change(input, { target: { value: '42' } }); | ||
|
|
||
| expect(onChange).toHaveBeenCalledWith('my-field', 42); | ||
| }); | ||
|
|
||
| it('handles empty value correctly', () => { | ||
| const onChange = jest.fn(); | ||
| render( | ||
| <Provider store={store}> | ||
| <NumberWidget | ||
| id="my-field" | ||
| value="1" | ||
| title="My field" | ||
| onChange={onChange} | ||
| /> | ||
| </Provider>, | ||
| ); | ||
|
|
||
| const input = screen.getByRole('spinbutton'); | ||
| fireEvent.change(input, { target: { value: '' } }); | ||
|
|
||
| expect(onChange).toHaveBeenCalledWith('my-field', undefined); | ||
| }); | ||
| }); | ||
|
|
||
| describe('onBlur behavior', () => { | ||
| it('calls onBlur with the current value', () => { | ||
| const onBlur = jest.fn(); | ||
| render( | ||
| <Provider store={store}> | ||
| <NumberWidget | ||
| id="my-field" | ||
| title="My field" | ||
| onBlur={onBlur} | ||
| value="123" | ||
| /> | ||
| </Provider>, | ||
| ); | ||
|
|
||
| const input = screen.getByRole('spinbutton'); | ||
| fireEvent.blur(input); | ||
|
|
||
| expect(onBlur).toHaveBeenCalled(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('validation constraints', () => { | ||
| it('respects minimum and maximum values', () => { | ||
| render( | ||
| <Provider store={store}> | ||
| <NumberWidget | ||
| id="my-field" | ||
| title="My field" | ||
| minimum={1} | ||
| maximum={100} | ||
| /> | ||
| </Provider>, | ||
| ); | ||
|
|
||
| const input = screen.getByRole('spinbutton'); | ||
| expect(input).toHaveAttribute('min', '1'); | ||
| expect(input).toHaveAttribute('max', '100'); | ||
| }); | ||
|
|
||
| it('handles step attribute', () => { | ||
| render( | ||
| <Provider store={store}> | ||
| <NumberWidget id="my-field" title="My field" step={0.5} /> | ||
| </Provider>, | ||
| ); | ||
|
|
||
| const input = screen.getByRole('spinbutton'); | ||
| expect(input).toHaveAttribute('step', '0.5'); | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.