Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image uses appropriate scales #102

Open
wants to merge 50 commits into
base: develop
Choose a base branch
from
Open

Image uses appropriate scales #102

wants to merge 50 commits into from

Conversation

andreiggr
Copy link
Contributor

  • no longer loading the full image, but loading large scale from plone, wide is going to get huge scale
  • images have width/height set, small req by lighthouse
  • image will use scales provided by plone
  • small performance improvement

@avoinea
Copy link
Member

avoinea commented Mar 15, 2023

@andreiggr Can you please rebase this branch on develop and fix the conflicting merge files?

ichim-david and others added 2 commits March 31, 2023 21:15
@ichim-david
Merge remote-tracking branch 'origin/develop' into image_scales_impro…
04a8c0b 
…vements

# Conflicts:
#	package.json
#	src/customizations/volto/components/manage/Blocks/Image/Edit.jsx
#	src/customizations/volto/components/manage/Blocks/Image/View.jsx
#	src/customizations/volto/components/manage/Blocks/Image/style.less
@andreiggr
fix: image scales and empty image input align
dfde255
@andreiggr andreiggr requested a review from ichim-david April 6, 2023 10:38
@andreiggr
Copy link
Contributor Author

Fixed image scales selector after rebase with develop changes

Also fixed an align for the image input, when there is no image url, but the align remains on the container
Before.
input bad align

After.
input good align if no img

andreiggr and others added 24 commits April 6, 2023 15:00
@andreiggr
clear wip
104ac33
@andreiggr
alt required
23293fb
@andreiggr
empty alt warning, default alt in case is empty
6e9fb28
@andreiggr
fix: image scales and empty image input align
d34630d
@andreiggr
no unused var
f6edff1
@andreiggr
fix more conflicts
6218a79
@andreiggr
alt warning style, fix image block sizes from scale
c098568
@andreiggr
remove style.less, add image.overrides/variables wip
f33a3d3
@andreiggr
load overrides/variables ok
c7edd1b
@andreiggr
update: tune image update on edit
dd3cb71
@ichim-david
Merge branch 'develop' into image_scales_improvements
7165f59
@nileshgulia1
feat: use icon image scales in objectBrowser thumbnails
39e90ff
@nileshgulia1
Merge branch 'develop' into image_scales_improvements
ce6b7df
@nileshgulia1
chore: add cypress for image-block"
9ab7cfc
@nileshgulia1
fix cypress
62e5970
@nileshgulia1
Merge branch 'develop' into image_scales_improvements
9233d0b
@nileshgulia1
fix(cypress): update logo url
1d210d7
@nileshgulia1
fix tests
7e4a4d4
@nileshgulia1
tests:update snapshots
9c59f29
@nileshgulia1
fix tests
024e423
@nileshgulia1
fix: tests failing due to aria-tag
cf4de5a
@nileshgulia1
add new tests to increase coverage
78837c1
@nileshgulia1
tests: missing hocs
2362d13
@nileshgulia1
specs: tests for getImageScaleParams
e5a0574
Base automatically changed from develop to master July 22, 2024 09:34
@avoinea avoinea changed the base branch from master to develop August 22, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichim-david ichim-david Awaiting requested review from ichim-david

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreiggr @avoinea @ichim-david @nileshgulia1