Allow placing the annotation element after the selected text #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the annotation view, inserted
<pb>
and<note>
elements are placed before the selected text.In the case of notes, however, it's common to insert them after the commented text.
I added new property
position
to the data passed to the functionaddAnnotation()
that is defined in thepb-view-annotate.js
web component,The default value of the
position
property isaround
and can be changed by specifying the valueafter
in the@class
attribute of the button for the element, for exampleIn the similar way, the value
before
in the@class
attribute is used now for elements that should be placed after the selected text.To be functional this change must be made at the same time as the change of the
pb-view-annotate.js
web component.See parallel required pull request in the Web Components for TEI Publisher.