Change the decoder convention from decodeX to xDecoder #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for this proposal is that a `Decoder x` is not a decode
function by itself. Instead, the true decode function looks something
like:
decodeX = decodeString xDecoder
This also differs from the generated encode functions that directly
encodes values.
This change makes that distinction more clear, which should aid
comprehension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this proposal is that a
Decoder xis not a decodefunction by itself. Instead, the true decode function looks something
like:
The generated decoders also differ from the generated encode functions (which do encode values directly).
This change makes that distinction more clear, which I believe ought to aid with comprehension.