Skip to content

Conversation

rupeshA
Copy link
Contributor

@rupeshA rupeshA commented Oct 29, 2018

@eeverman , please have a look, I have tried hand on #218

@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #454 into master will decrease coverage by 1.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   78.97%   77.63%   -1.34%     
==========================================
  Files         122      119       -3     
  Lines        3781     3533     -248     
  Branches      635      569      -66     
==========================================
- Hits         2986     2743     -243     
+ Misses        612      607       -5     
  Partials      183      183
Impacted Files Coverage Δ
...va/org/yarnandtail/andhow/NonProductionConfig.java 75% <ø> (ø) ⬆️
...rg/yarnandtail/andhow/AndHowNonProductionUtil.java 73.8% <ø> (ø) ⬆️
...andtail/andhow/compile/AndHowCompileProcessor.java 78.65% <0%> (-12.53%) ⬇️
...va/org/yarnandtail/andhow/compile/CompileUnit.java 67.21% <0%> (-11.68%) ⬇️
...va/org/yarnandtail/andhow/internal/AndHowCore.java 74.75% <0%> (-3.82%) ⬇️
...ndhow/compile/PropertyRegistrarClassGenerator.java 97.43% <0%> (-2.57%) ⬇️
...andtail/andhow/compile/AndHowCompileException.java
...org/yarnandtail/andhow/compile/CompileProblem.java
.../org/yarnandtail/andhow/internal/InternalUtil.java
...in/java/org/yarnandtail/andhow/util/AndHowLog.java 91.66% <0%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09bebf7...201448e. Read the comment docs.

@code4t2
Copy link
Collaborator

code4t2 commented Oct 29, 2018

The maven-javadoc-plugin plugin declaration is duplicated, @rupeshA . I think @eeverman was referring to customizing the Javadocs using the doclet feature that the JDK provides

Copy link
Owner

@eeverman eeverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #218 is not creating javadocs for the AndHow project - Javadocs for this project already work.
This issue is about having AndHow create documentation for the project you are using it in.
So for instance, if you create MyProject that uses AndHow Properties, when you run JavaDocs, AndHow should create documentation for all of the configuration properties in MyProject and include them in the javadoc for MyProject.

That would be pretty cool, right? :-)
Sorry, that task was not well defined - I wasn't expecting someone to work on it yet. Thanks for trying on this one, however.

* Sets a new {@code AndHowCore}
*
* This inserts an entire new state into AndHow. Inserting a {@null} core
* This inserts an entire new state into AndHow. Inserting a {@code null} core
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

pom.xml Outdated
</goals>
</execution>
</executions>
</plugin>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we do not want this here. Can you pull this out and we can keep the other cleanup that you have in the pull request?

@eeverman
Copy link
Owner

I updated the description of #218

@rupeshA
Copy link
Contributor Author

rupeshA commented Oct 30, 2018

@eeverman , sounds cool indeed, will give thought to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants