Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIP-36: Games of Capture and Escape #130

Merged
merged 8 commits into from
Apr 4, 2024
Merged

DIP-36: Games of Capture and Escape #130

merged 8 commits into from
Apr 4, 2024

Conversation

gichiba
Copy link
Contributor

@gichiba gichiba commented Feb 24, 2024 •
edited by ligi
Loading

Here I add DIP-36 on behalf of daedalus.industries

@gichiba gichiba changed the title add DIP-34 add DIP-42 Feb 24, 2024
@ligi ligi changed the title add DIP-42 DIP-36: Games of Capture and Escape Feb 24, 2024
ligi
ligi requested changes Feb 24, 2024
View reviewed changes
Copy link
Member

@ligi ligi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting DIP!
Some nits - also please rename file to dip-36.md

DIPs/DIP-42.md Outdated Show resolved Hide resolved
DIPs/DIP-42.md Outdated Show resolved Hide resolved
DIPs/DIP-42.md Outdated Show resolved Hide resolved
DIPs/DIP-42.md Outdated Show resolved Hide resolved
DIPs/DIP-42.md Outdated Show resolved Hide resolved
@gichiba @ligi
add DIP-36
51a361b 
fix DIP-34 name collision

Update DIPs/DIP-42.md

Co-authored-by: ligi <ligi@ligi.de>

Update DIPs/DIP-42.md

Co-authored-by: ligi <ligi@ligi.de>

Update DIPs/DIP-42.md

Co-authored-by: ligi <ligi@ligi.de>

Update DIPs/DIP-42.md

Co-authored-by: ligi <ligi@ligi.de>

Update DIPs/DIP-42.md

Co-authored-by: ligi <ligi@ligi.de>
@gichiba
Copy link
Contributor Author

gichiba commented Feb 24, 2024

squashed and cleaned up the commits, thanks for catching the typos @ligi !

@ligi
Copy link
Member

ligi commented Feb 25, 2024

Thanks! Can u also rename to dip-36.md - otherwise CI is not happy

@gichiba
Copy link
Contributor Author

gichiba commented Mar 4, 2024

Done!

@gichiba gichiba requested a review from ligi March 11, 2024 16:35
@ligi
Copy link
Member

ligi commented Mar 14, 2024 •
edited
Loading

Checklist

  • Correct markdown (e.g. headers with ##, header surrounded by ---)
  • syntax check
  • filename is DIP-X.md (with X being the correct DIP number)
  • header contains (in this order)
    • DIP
    • Title
    • Status
    • Themes
    • Tags
    • Authors
    • Resources Required (optional)
    • Discussion (with link to devcon forum)
    • Created (in the format year-month-day e.g 2020-4-20)
  • contains these sections:
    • Abstract
    • Rationale
    • Implementation
    • Operational Requirements & Ownership
  • PR title prefixed with DIP-X

ligi
ligi requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Can you do the post on the DEVCon forum?
Also we need more details on what you need from us

ligi
ligi requested changes Mar 28, 2024
View reviewed changes
DIPs/DIP-36.md Outdated Show resolved Hide resolved
DIPs/DIP-36.md Outdated Show resolved Hide resolved
DIPs/DIP-36.md Outdated Show resolved Hide resolved
Griffin Ichiba Hotchkiss and others added 3 commits April 1, 2024 16:43
@ligi
Update DIPs/DIP-36.md
7b37ed3 
Co-authored-by: ligi <ligi@ligi.de>
@ligi
Update DIPs/DIP-36.md
64c7772 
Co-authored-by: ligi <ligi@ligi.de>
@ligi
Update DIPs/DIP-36.md
0422ce8 
Co-authored-by: ligi <ligi@ligi.de>
@ligi ligi merged commit a0104ee into efdevcon:master Apr 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligi ligi ligi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gichiba @ligi