Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIP-44 - Devcon Agora application #144

Merged
merged 4 commits into from
Aug 26, 2024
Merged

DIP-44 - Devcon Agora application #144

merged 4 commits into from
Aug 26, 2024

Conversation

nagysandorantal
Copy link
Contributor

@nagysandorantal nagysandorantal commented Jul 29, 2024 •
edited by ligi
Loading

Description

Related DIP issue

Checklist

  • Correct markdown (e.g. headers with ##, header surrounded by ---)
  • syntax check
  • filename is DIP-X.md (with X being the correct DIP number)
  • header contains (in this order)
    • DIP
    • Title
    • Status
    • Themes
    • Tags
    • Authors
    • Resources Required (optional)
    • Discussion (with link to devcon forum)
    • Created (in the format year-month-day e.g 2020-4-20)
  • contains these sections:
    • Abstract
    • Rationale
    • Implementation
    • Operational Requirements & Ownership
  • PR title prefixed with DIP-X

@nagysandorantal nagysandorantal marked this pull request as ready for review August 5, 2024 10:51
ligi
ligi requested changes Aug 21, 2024
View reviewed changes
DIPs/DIP-44.md Outdated

## Links & Additional Information

* Learn more about th Solar Punk team at: https://solarpunk.buzz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Learn more about th Solar Punk team at: https://solarpunk.buzz
* Learn more about the Solar Punk team at: https://solarpunk.buzz

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should apply the suggested change - not just thumbs up ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ligi, applied the change now.

@nagysandorantal nagysandorantal requested a review from ligi August 21, 2024 19:12
ligi
ligi requested changes Aug 22, 2024
View reviewed changes
DIPs/DIP-44.md Outdated

## Links & Additional Information

* Learn more about th Solar Punk team at: https://solarpunk.buzz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should apply the suggested change - not just thumbs up ;-)

@ligi ligi merged commit af9cc58 into efdevcon:master Aug 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aranyia aranyia aranyia left review comments

@ligi ligi ligi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nagysandorantal @ligi @aranyia