Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windowsでc++20を指定してビルドをする場合エラーが発生する現象を修正 #972

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

rumichi2210
Copy link
Contributor

std::minがwindows.hにある関数マクロと競合してしまうため(std::min)に変更
https://cpprefjp.github.io/reference/algorithm/min.html
備考より

back_inserterを使用するために
#include <iterator>の追加

windows環境以外でテスト出来ていないため、他の環境でビルド出来る方は宜しくお願いいたします。

@durswd
Copy link
Collaborator

durswd commented Nov 19, 2023

CIで全環境のビルドテストしているのでそこは確認できます。

@durswd durswd merged commit 7e5bbf2 into effekseer:master Nov 19, 2023
6 checks passed
@durswd
Copy link
Collaborator

durswd commented Nov 19, 2023

ありがとうございました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants