Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open manual error #997

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Fix open manual error #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7603987
Fix open manual error
SQwatermark Feb 7, 2024
c1617f5
Fix usages of Process.Start()
SQwatermark Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Dev/Editor/EffekseerCoreGUI/GUI/Commands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,12 @@ static public bool ShowURL(string url)
{
try
{
System.Diagnostics.Process.Start(url);
var info = new System.Diagnostics.ProcessStartInfo
{
FileName = url,
UseShellExecute = true
};
System.Diagnostics.Process.Start(info);
}
catch
{
Expand Down
22 changes: 19 additions & 3 deletions Dev/Editor/EffekseerCoreGUI/GUI/Dock/FileBrowser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,12 @@ private void OnFilePicked()
try
{
// open process
System.Diagnostics.Process.Start(fileItem.FilePath);
var info = new System.Diagnostics.ProcessStartInfo
{
FileName = fileItem.FilePath,
UseShellExecute = true
};
System.Diagnostics.Process.Start(info);
}
catch (Exception)
{
Expand All @@ -747,11 +752,22 @@ private void ShowInFileManager()

if (swig.GUIManager.IsMacOSX())
{
System.Diagnostics.Process.Start("open", dirPath);
var info = new System.Diagnostics.ProcessStartInfo
{
FileName = "open",
Arguments = dirPath,
UseShellExecute = true
};
System.Diagnostics.Process.Start(info);
}
else
{
System.Diagnostics.Process.Start(dirPath);
var info = new System.Diagnostics.ProcessStartInfo
{
FileName = dirPath,
UseShellExecute = true
};
System.Diagnostics.Process.Start(info);
}
}
catch (Exception)
Expand Down
7 changes: 6 additions & 1 deletion Dev/Editor/EffekseerCoreGUI/GUI/Manager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,12 @@ public override bool ClickLink(string path)
{
try
{
System.Diagnostics.Process.Start(path);
var info = new System.Diagnostics.ProcessStartInfo
{
FileName = path,
UseShellExecute = true
};
System.Diagnostics.Process.Start(info);
}
catch
{
Expand Down
Loading