Skip to content

fix: Model with dependencies not work as expect#145

Merged
durswd merged 1 commit intoeffekseer:masterfrom
scarletsky:fix/efkpkg-with-efkmodel
Jan 29, 2026
Merged

fix: Model with dependencies not work as expect#145
durswd merged 1 commit intoeffekseer:masterfrom
scarletsky:fix/efkpkg-with-efkmodel

Conversation

@scarletsky
Copy link
Contributor

See the following metafile.json

"47F5F8C57ED31F7D2A27F9F4D6DDBFBF-0000A8B0": {
  "type": "Model",
  "relative_path": "guandaojiantou_red_1.fbx",
  "dependencies": ["2E798BE9E9054BA87755A53C923C574B-000127F8"]
},
"2E798BE9E9054BA87755A53C923C574B-000127F8": {
  "type": "Model",
  "relative_path": "guandaojiantou_red_1.efkmodel"
},

If Model has dependencies, the effect will miss model in runtime.

This PR works like #140 , just make the UID points to the dependencies buffer.

@scarletsky
Copy link
Contributor Author

Maybe we can make it more generic, just check fileInfo.dependencies ?

- } else if (fileInfo.type === 'Model' && fileInfo.dependencies) {
+ } else if (fileInfo.dependencies) {

@durswd durswd merged commit c17cfe5 into effekseer:master Jan 29, 2026
3 checks passed
@durswd
Copy link
Contributor

durswd commented Jan 29, 2026

I think that it cannot make it more generic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants