Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vscode dependencies #43

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Update vscode dependencies #43

merged 1 commit into from
Dec 20, 2024

Conversation

b-studios
Copy link
Collaborator

No description provided.

@b-studios
Copy link
Collaborator Author

There is already https://github.com/effekt-lang/effekt-vscode/tree/jiribenes/update-vscode which should be subsumed by this a bit newer one here.

jiribenes
jiribenes approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@jiribenes jiribenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only difference is that the mentioned branch also updated the scaffolding based on the official VSCode examples. But if this works locally, then we can ship it :shipit:

@b-studios b-studios merged commit 212f259 into master Dec 20, 2024
1 check passed
@b-studios b-studios deleted the update-dependencies branch December 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiribenes jiribenes jiribenes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-studios @jiribenes