Mark unlikely calls in LLVM as cold #1169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@phischu could you check if you want this / if it makes any difference for the LLVM benchmarks? if so, feel free to merge it :) |
jiribenes
commented
Oct 29, 2025
Comment on lines
+9
to
+10
| declare void @hole(i8*) cold | ||
| declare void @duplicated_prompt() cold |
Contributor
Author
There was a problem hiding this comment.
My hypothesis is that the hole (panic: not implemented yet) being cold doesn't matter at all, but the duplicated_prompt might by a tiny bit since I assuming used stacks are non-null seems good...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.