Handle schema parse errors #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastinez
added a commit
to radicle-dev/radicle-explorer
that referenced
this pull request
Nov 25, 2024
Also moving the svelte-stored-writable package into the repo. So we have it closer for maintenance, we can eventually rewrite it in svelte 5 runes later. Reference: efstajas/svelte-stored-writable#5
sebastinez
added a commit
to radicle-dev/radicle-explorer
that referenced
this pull request
Nov 25, 2024
Also moving the svelte-stored-writable package into the repo. So we have it closer for maintenance, we can eventually rewrite it in svelte 5 runes later. Reference: efstajas/svelte-stored-writable#5
sebastinez
added a commit
to radicle-dev/radicle-explorer
that referenced
this pull request
Nov 25, 2024
Also moving the svelte-stored-writable package into the repo. So we have it closer for maintenance, we can eventually rewrite it in svelte 5 runes later. Reference: efstajas/svelte-stored-writable#5
If there is an existing localStorage entry for `key`, the library should not throw an error, but replace the existing `localStorage` entry with the `initialValue`. This allows users of this library to modify stores with new schemas with ease.
sebastinez
force-pushed
the
sebastinez/handle-schema-parse-errors
branch
from
0ab6e78 to
b1c810c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an existing localStorage entry for
key, the library should not throw an error, but replace the existinglocalStorageentry with theinitialValue.This allows users of this library to modify stores with new schemas with ease.
I'm aware that this can also be handled by users of this library with a
try catch, though IMO most people would prefer to instantiate their stores as mentioned in theREADME, but without the possible foot gun that their deployments are gonna break.Open for any feedback or changes.