Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index.d.ts关于xframe.value的声明中“ALLOW-FROM”有问题 #5306

Closed
woaixiangbao opened this issue Apr 17, 2024 · 2 comments · Fixed by #5336
Closed

index.d.ts关于xframe.value的声明中“ALLOW-FROM”有问题 #5306

woaixiangbao opened this issue Apr 17, 2024 · 2 comments · Fixed by #5336
Labels
PR is welcome

Comments

@woaixiangbao
Copy link

在此输入你需要反馈的 Bug 具体信息（Bug in Detail）：

如果value的值等于“ALLOW-FROM”是没问题的，不过xframe.value应该设置为“ALLOW-FROM http//:xxx.com”这种形式才对。这里的ALLOW-FROM后面跟任何字符都会被ts判定失败从而报错。

可复现问题的仓库地址（Reproduction Repo）

一直都有

Node 版本号：

最新版

Eggjs 版本号：

最新版

相关插件名称与版本号（PlugIn and Name）：

最新版

操作平台与版本号（Platform and Version）：

最新版
@woaixiangbao woaixiangbao changed the title index.d.ts关于xframe.value的声明有问题中“ALLOW-FROM”有问题 index.d.ts关于xframe.value的声明中“ALLOW-FROM”有问题 Apr 17, 2024
@fengmk2
Copy link
Member

fengmk2 commented Apr 17, 2024

可以来个 pr 修复一下。

@hongzzz hongzzz mentioned this issue Jul 3, 2024
Merged
4 tasks
@coderabbitai coderabbitai bot mentioned this issue Jul 4, 2024
Open
4 tasks
@fengmk2
Copy link
Member

fengmk2 commented Sep 15, 2024

#5336

@fengmk2 fengmk2 closed this as completed Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR is welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: xframe value type hongzzz/egg
2 participants
@fengmk2 @woaixiangbao