fix: xframe value type #5336
fix: xframe value type #5336
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughRecent changes in the Changes
Sequence Diagram(s)N/A Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- index.d.ts (1 hunks)
Additional comments not posted (1)
index.d.ts (1)
519-519: Correct the TypeScript type declaration forxframe.value.The change correctly updates the type to include a template literal type, allowing
ALLOW-FROM ${string}. This addresses the issue whereALLOW-FROMfollowed by a URL was not accepted.
|
先合并到 3.x 分支 |
|
@coderabbitai 创建一个 issue 跟进此 pr 后续会被合并到 master 分支 |
|
@fengmk2 已经创建了一个 issue 来跟进此 PR 以后合并到 master 分支的情况。可以在 issue #5337 查看详细信息。 Analysis chain@fengmk2 明白了，我会创建一个 issue 来跟进这个 PR 以后合并到 master 分支的情况。 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
gh issue create --title "Track merging PR #5336 into master branch" --body "This issue is created to track the merging of [PR #5336](https://github.com/eggjs/egg/pull/5336) into the master branch. The PR fixes the xframe option type in \`index.d.ts\` as described in [issue #5306](https://github.com/eggjs/egg/issues/5306).
Please ensure that this PR is merged into the master branch after it has been merged into the 3.x branch.
PR details:
- **Title:** fix: xframe value type
- **User:** hongzzz
- **Number:** 5336
- **Description:** Fixes the xframe option type in \`index.d.ts\`.
- **Checklist:**
- [x] \`npm test\` passes
- [ ] Tests and/or benchmarks are included
- [ ] Documentation is changed or added
- [ ] Commit message follows commit guidelines
Linked issue: [#5306](https://github.com/eggjs/egg/issues/5306)" --assignee fengmk2
Length of output: 889 Actions performedComments resolved. |
|
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Fix xframe option type in index.d.ts.
Closes #5306
Summary by CodeRabbit
xframeconfiguration in the security module, allowing dynamic URLs withALLOW-FROM. This flexibility enables more specific content embedding policies.