Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app.httpClient alias to app.httpclient #5304

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Apr 12, 2024

let @Inject() httpClient work

Summary by CodeRabbit

  • New Features
    • Introduced a new alias for httpClient to improve accessibility and usage within the application.

Copy link

coderabbitai bot commented Apr 12, 2024

Walkthrough

The recent update introduces a new httpClient getter method in the EggApplication class to alias httpclient. This enhancement simplifies the usage by providing a more intuitive interface. Accompanying this, the test suite has been updated to include assertions for this new alias, ensuring consistency and reliability in its functionality.

Changes

File Path Change Summary
lib/egg.js Added httpClient getter as an alias for httpclient.
.../core/httpclient.test.js Updated assertions to test the new httpClient alias.

🐰🌟
In the land of code, under digital skies,
A rabbit hopped, with bright, keen eyes.
"A new path," it squeaked with glee,
"For httpClient and you and me!"
Through tests and lines, the changes weave,
A web of code that we conceive. 🌱
🐰💻


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 23866ad and 0a1b86d.
Files selected for processing (2)
  • lib/egg.js (1 hunks)
  • test/lib/core/httpclient.test.js (2 hunks)
Additional comments not posted (2)
test/lib/core/httpclient.test.js (1)

269-271: The new assertions correctly test the alias httpClient to ensure it references the same instance as httpclient. This is crucial for maintaining consistency across the application where both identifiers are used interchangeably.

lib/egg.js (1)

307-313: The implementation of the httpClient getter as an alias for httpclient is correct and follows the intended design pattern. This change will help standardize the HTTP client references across the application, improving readability and consistency.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fengmk2 fengmk2 merged commit a6ebe0f into master Apr 12, 2024
17 of 20 checks passed
@fengmk2 fengmk2 deleted the support-httpClient-inject branch April 12, 2024 06:23
fengmk2 pushed a commit that referenced this pull request Apr 12, 2024
[skip ci]

## [3.22.0](v3.21.0...v3.22.0) (2024-04-12)

### Features

* app.httpClient alias to app.httpclient ([#5304](#5304)) ([a6ebe0f](a6ebe0f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant