Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs #5317

Merged
merged 1 commit into from
Jun 7, 2024
Merged

docs: update docs #5317

merged 1 commit into from
Jun 7, 2024

Conversation

sinkhaha
Copy link
Contributor

@sinkhaha sinkhaha commented May 27, 2024

Description of change

update document link display error

fixs #5318

Summary by CodeRabbit

  • Documentation
    • Updated reference links in advanced loader documentation for easier navigation.
    • Added a section with reference links in core HTTP client documentation.
    • Improved link formatting in Chinese versions of advanced loader and core HTTP client documentation.

Copy link

coderabbitai bot commented May 27, 2024

Walkthrough

The recent updates primarily focus on improving the documentation by refining reference links. In the loader.md files, unnecessary code snippets were replaced with direct GitHub links. Similarly, the httpclient.md files saw the addition of a new reference section and format adjustments for better readability.

Changes

Files Change Summary
site/docs/advanced/loader.md Updated reference links by removing code snippets and adding direct GitHub links.
site/docs/advanced/loader.zh-CN.md Converted reference links from markdown format to direct hyperlinks.
site/docs/core/httpclient.md Added a new section titled "Other Reference Links" with a list of related links.
site/docs/core/httpclient.zh-CN.md Updated reference links by removing colons and changing the format to inline links.

In the land of code so bright,
Documentation took a flight.
Links now clear, in plain sight,
Making learning a pure delight.
With each update, day and night,
Our knowledge grows, reaching new height.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (2)
site/docs/advanced/loader.zh-CN.md (2)

Line range hint 284-284: Correct the link fragment for better navigation.

- [caseStyle](#caseStyle-string)
+ [caseStyle](#casestyle-string)

Line range hint 392-392: Correct the link fragment for better navigation.

- [LoaderOptions](#LoaderOptions)
+ [LoaderOptions](#loaderoptions)
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between d68ab6a and 6f13175.
Files selected for processing (4)
  • site/docs/advanced/loader.md (1 hunks)
  • site/docs/advanced/loader.zh-CN.md (1 hunks)
  • site/docs/core/httpclient.md (1 hunks)
  • site/docs/core/httpclient.zh-CN.md (1 hunks)
Additional Context Used
Markdownlint (68)
site/docs/advanced/loader.md (15)

539: Expected: 1; Actual: 2
Multiple consecutive blank lines


534: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


534: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


533: null
Fenced code blocks should be surrounded by blank lines


535: null
Lists should be surrounded by blank lines


80: null
Fenced code blocks should have a language specified


98: null
Fenced code blocks should have a language specified


145: null
Fenced code blocks should have a language specified


156: null
Fenced code blocks should have a language specified


247: null
Images should have alternate text (alt text)


280: Expected: #casestyle-string; Actual: #caseStyle-string
Link fragments should be valid


390: Expected: #loaderoptions; Actual: #LoaderOptions
Link fragments should be valid


126: Expected: 4; Actual: 3; Too few cells, row will be missing data
Table column count


127: Expected: 4; Actual: 3; Too few cells, row will be missing data
Table column count


134: Expected: 4; Actual: 3; Too few cells, row will be missing data
Table column count

site/docs/advanced/loader.zh-CN.md (19)

502: Expected: 1; Actual: 2
Multiple consecutive blank lines


93: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


191: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


285: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


351: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


423: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


92: null
Fenced code blocks should be surrounded by blank lines


190: null
Lists should be surrounded by blank lines


462: null
Lists should be surrounded by blank lines


479: null
Lists should be surrounded by blank lines


538: null
Lists should be surrounded by blank lines


80: null
Fenced code blocks should have a language specified


97: null
Fenced code blocks should have a language specified


150: null
Fenced code blocks should have a language specified


161: null
Fenced code blocks should have a language specified


251: null
Images should have alternate text (alt text)


540: null
Files should end with a single newline character


284: Expected: #casestyle-string; Actual: #caseStyle-string
Link fragments should be valid


392: Expected: #loaderoptions; Actual: #LoaderOptions
Link fragments should be valid

site/docs/core/httpclient.md (5)

800: Expected: 1; Actual: 2
Multiple consecutive blank lines


707: null
Dollar signs used before commands without showing output


802: null
Lists should be surrounded by blank lines


62: null
Bare URL used


588: null
Spaces inside code span elements

site/docs/core/httpclient.zh-CN.md (29)

692: null
Dollar signs used before commands without showing output


55: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


166: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


268: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


384: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


500: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


624: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


699: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


704: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


709: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


714: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


719: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


724: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


728: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines


54: null
Fenced code blocks should be surrounded by blank lines


165: null
Fenced code blocks should be surrounded by blank lines


267: null
Fenced code blocks should be surrounded by blank lines


383: null
Fenced code blocks should be surrounded by blank lines


499: null
Fenced code blocks should be surrounded by blank lines


639: null
Lists should be surrounded by blank lines


700: null
Lists should be surrounded by blank lines


705: null
Lists should be surrounded by blank lines


710: null
Lists should be surrounded by blank lines


715: null
Lists should be surrounded by blank lines


720: null
Lists should be surrounded by blank lines


725: null
Lists should be surrounded by blank lines


727: null
Lists should be surrounded by blank lines


779: null
Lists should be surrounded by blank lines


733: null
Fenced code blocks should have a language specified

Additional comments not posted (1)
site/docs/advanced/loader.zh-CN.md (1)

538-540: Ensure that the hyperlinks are correctly formatted and accessible.

Verification successful

The hyperlinks in the documentation are correctly formatted and accessible.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the accessibility of the hyperlinks.

# Test: Check if the URLs are accessible. Expect: HTTP 200 OK responses.
curl -o /dev/null -s -w "%{http_code}\n" https://github.com/eggjs/egg-core/blob/master/lib/loader/egg_loader.js
curl -o /dev/null -s -w "%{http_code}\n" https://github.com/eggjs/egg/blob/master/lib/loader/app_worker_loader.js
curl -o /dev/null -s -w "%{http_code}\n" https://github.com/eggjs/egg/blob/master/lib/loader/agent_worker_loader.js

Length of output: 359

Comment on lines +779 to +785
- [urllib](https://github.com/node-modules/urllib)
- [httpclient](https://github.com/eggjs/egg/blob/master/lib/core/httpclient.js)
- [formstream](https://github.com/node-modules/formstream)
- [http](https://nodejs.org/api/http.html)
- [https](https://nodejs.org/api/https.html)
- [charles](https://www.charlesproxy.com/)
- [fiddler](http://www.telerik.com/fiddler)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The verification script has confirmed that all the URLs are accessible and correctly formatted, except for the last URL (http://www.telerik.com/fiddler), which returned an HTTP 301 status code, indicating it has been moved permanently. This suggests that the URL should be updated to its new location.

Analysis chain

Ensure that the hyperlinks are correctly formatted and accessible.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the accessibility of the hyperlinks.

# Test: Check if the URLs are accessible. Expect: HTTP 200 OK responses.
curl -o /dev/null -s -w "%{http_code}\n" https://github.com/node-modules/urllib
curl -o /dev/null -s -w "%{http_code}\n" https://github.com/eggjs/egg/blob/master/lib/core/httpclient.js
curl -o /dev/null -s -w "%{http_code}\n" https://github.com/node-modules/formstream
curl -o /dev/null -s -w "%{http_code}\n" https://nodejs.org/api/http.html
curl -o /dev/null -s -w "%{http_code}\n" https://nodejs.org/api/https.html
curl -o /dev/null -s -w "%{http_code}\n" https://www.charlesproxy.com/
curl -o /dev/null -s -w "%{http_code}\n" http://www.telerik.com/fiddler

Length of output: 602

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (23866ad) to head (6f13175).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5317   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          36       36           
  Lines        3620     3628    +8     
  Branches      519      520    +1     
=======================================
+ Hits         3615     3623    +8     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 merged commit fb48636 into eggjs:master Jun 7, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants