fix: serverTimeout default to 0 (no timeout)

[fengmk2]

typo fix on onProtoPoisoning, should be 400 response

Summary by CodeRabbit

• Bug Fixes

  • Updated the response code for Prototype-Poisoning from 403 to 400.

• Configuration Changes

  • Changed the default server timeout setting to 0 (no timeout).

[coderabbitai]

Walkthrough

The recent update modifies the default server timeout settings and response codes for the egg module. Specifically, the server timeout is set to 0 (no timeout), and the response code for Prototype-Poisoning is changed from 403 to 400. These changes aim to improve server performance and error handling.

Changes

Files	Change Summary
config/config.default.js	Updated config.workerStartTimeout from 10 minutes to 0 (no timeout).
index.d.ts	Modified bodyParser response for Prototype-Poisoning from 403 to 400, and server timeout to 0.

Poem

🐇 In the code where changes flow,
Timeouts now set to zero.
Errors once were 403,
Now they're 400, clear to see.
Performance shines, the server's bright,
With these tweaks, all feels right. 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

index.d.ts (1)

535-535: Changing the default server timeout to 0 (no timeout) is a significant change that could lead to potential issues with hanging requests if not handled properly in the application logic.

Consider implementing application-level timeouts where necessary to prevent resource exhaustion.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3ddbd06 and d8c1ac1.

Files selected for processing (2)

• config/config.default.js (1 hunks)
• index.d.ts (3 hunks)

Files skipped from review due to trivial changes (1)

• config/config.default.js

Additional comments not posted (2)

index.d.ts (2)

333-333: Update to response code for Prototype-Poisoning is consistent with PR description.

---

355-355: Ensure that the new default behavior (400 response for Prototype-Poisoning) is well-documented and communicated to users, as it changes the API behavior.