refactor: Remove dictionary creation from SwapStyleBuilder #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the naming convention of the SwapStyle enum to match htmx attribute casing. This change affects several files where this enum is used, including HtmxConfig.cs, SwapStyleEnumConverter.cs, and various test files. The refactor allows correct serialization if used in blazor markup.
Updated the reference to ScrollBehavior.smooth in the HtmxConfig class.
Significant changes include: - Created a new class, HtmxSwapSpecification, to represent an htmx swap specification. - Refactored SwapStyleBuilder to use the new HtmxSwapSpecification instead of individual properties and methods for each modifier. - Simplified the Build method in SwapStyleBuilder to generate a string based on the current state of the HtmxSwapSpecification instance. - Updated tests to reflect these changes.
egil
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went back and looked through the htmx source and it appears as though your original comment about whether ordering mattered for the SwapStyleBuilder was on the money. Every part of the swap specification is parsed into a single SwapSpec object so I created an object that would at least hold the values for the commands. This would ensure that no command would be repeated. The builder then just produces the final string result from the HtmxSwapSpecification record. The tests were updated accordingly to use SwapStyle.Default which equates to the empty string.