Fix default skin model for getRenders

egorprnn · Mar 28, 2021 · 4b28c8c · 4b28c8c
1 parent c61cc0d
commit 4b28c8c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "namemcwrapper",
-  "version": "1.8.3",
+  "version": "1.8.4",
   "description": "ES6 Promise based wrapper for NameMC.com",
   "main": "./dist/NameMC.js",
   "exports": {

diff --git a/src/DataParser.ts b/src/DataParser.ts
@@ -339,8 +339,8 @@ export abstract class DataParser {
         switch(type) {
             case "skin": {
                 const name = (response as ISkinResponse).name || null;
-                const model = (response as ISkinResponse).model || (this.options.defaultSkinsModel || "unknown");
                 const rating = (response as ISkinResponse).rating ?? 0;
+                const model = (response as ISkinResponse).model || this.options.defaultSkinsModel || "unknown";
 
                 return {
                     url,

diff --git a/src/NameMC.ts b/src/NameMC.ts
@@ -153,8 +153,6 @@ export class NameMC extends DataParser {
     }: IGetRendersOptions): IRender {
         const endpoint: string = this.getEndpoint({ subdomain: "render" });
 
-        model = model || this.options.defaultSkinsModel;
-
         return {
             body: {
                 front: `${endpoint}/skin/3d/body.png?skin=${skin}&model=${model}&width=${width}&height=${height}&theta=${theta}&phi=${phi}&time=${time}`,