-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop Code sync up #788
Merged
Merged
Develop Code sync up #788
Changes from all commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
b8813f0
PFM-5822: forgot password fixes WIP
anilsingha-eGov 7567198
PFM-5822:Fixed forgot password not redirecting,added validation for p…
anilsingha-eGov b8988fa
PFM-5882: Updatd mobile
anilsingha-eGov ded45aa
PFM-5822: Updated css
anilsingha-eGov 1dfbb70
PFM-5822:Updated max and min length to 15 for change password
anilsingha-eGov 70cd6fc
PFM-5822: Updated css in index.html
anilsingha-eGov 8d12ad4
Merge pull request #751 from egovernments/PFM-5822
anilsingha-eGov 022b3d2
PFM-5842: Fixed category & subcategory value showing null
anilsingha-eGov 50cba4d
Revert "PFM-5842: Fixed category & subcategory value showing null"
anilsingha-eGov 2cf7ca6
PFM-5842: Fixed category & subcategory value showing null
anilsingha-eGov cde3e5d
Merge pull request #757 from egovernments/PFM-5842
pradeepkumarcm-egov 043553e
PFM-5968:Updated password to max 10
anilsingha-eGov 47b6d3c
Merge pull request #758 from egovernments/develop-digit-ui
pradeepkumarcm-egov 608f00b
PFM-5969: Added select all for roles dropdown
anilsingha-eGov 71e10c9
Merge pull request #759 from egovernments/PFM-5969
pradeepkumarcm-egov c5611ab
PFM-5983: Password length max set to 10, Fixed uppercase not giving hint
anilsingha-eGov 8623f97
Merge pull request #760 from egovernments/PFM-5983-flutter
pradeepkumarcm-egov 8508a99
PFM-5973 Added condtion to open any dashboard in new tab
chinmoy-eGov b8c7ae3
PFM-5973 Added condtion to open any dashboard in new tab
chinmoy-eGov 9344f2e
Merge pull request #761 from egovernments/PFM-5973
anilsingha-eGov 3ed308a
PFM-5971 added filter for current tenant
chinmoy-eGov a7cd53f
Merge pull request #762 from egovernments/PFM-5971
anilsingha-eGov f612d14
PFM-5984 Added Eye for password visibility
chinmoy-eGov 2044be5
PFM-5984 Addition of password icon
chinmoy-eGov 8b84303
PFM-5984 Addition of password icon
chinmoy-eGov 2936f24
PFM-5996: Fixed employee side bar not working
anilsingha-eGov e3e14da
PFM-5996: Fixed employee side bar not working ( #765 )
anilsingha-eGov b50389f
PFM-5971 Added a default function to select a default jurisdiction fo…
chinmoy-eGov 3d43c79
PFM-5971 Added a default function to select a default jurisdiction ( …
anilsingha-eGov 35fda66
PFM-5998: Added Sarpanch, Secretory, Revenue Collector
anilsingha-eGov 9ac3a8c
PFM-5998: Added Sarpanch, Secretory, Revenue Collector ( #768 )
anilsingha-eGov cf33eb9
Update application.properties
Saloni-eGov 07c3c3d
Merge pull request #769 from egovernments/saloni041-patch-3
pradeepkumarcm-egov 2dc3991
ISTE-17 Password icon change
chinmoy-eGov 6d9d97f
ISTE-19: Updated password for profile
anilsingha-eGov 8eab20e
ISTE-19: Updated password for profile ( #770 )
anilsingha-eGov cffa35f
PFM-5984 Added Eye for password visibility ( #764 )
anilsingha-eGov 786ac8d
ISTE-7,ISTE-20: Fixed Revenue Collector roles issue
anilsingha-eGov 52d44f4
ISTE-7,ISTE-20: Fixed Revenue Collector roles issue ( #771 )
anilsingha-eGov f610ab0
ISTE-17 Changes in password component
chinmoy-eGov b24c6ae
Added password not taking props
anilsingha-eGov 1d2c20a
Merge pull request #772 from egovernments/password-fix
anilsingha-eGov 5a30509
Merge branch 'develop' of https://github.com/egovernments/punjab-mgra…
chinmoy-eGov ec5c4f1
ISTE-17 Changes in password component ( #773 )
anilsingha-eGov c6e0ea2
ISTE-19: Foxed minlentgh issue
anilsingha-eGov befcab5
ISTE-19: Fixed minlength issue ( #774 )
anilsingha-eGov cd0613b
ISTE-20: Added sarpanch,revenue collector, secretory & Updated role
anilsingha-eGov 5c48d28
ISTE-20: Added sarpanch,revenue collector, secretory & Updated role (…
anilsingha-eGov fc40dab
ISTE-19: Fixed forgot password issue
anilsingha-eGov ac7bad3
ISTE-19: Fixed forgot password issue ( #776 )
anilsingha-eGov 4ce98e5
ISTE-8 Modification for role dropdown
chinmoy-eGov c027c07
Merge branch 'develop' of https://github.com/egovernments/punjab-mgra…
chinmoy-eGov d47c92a
Merge branch 'ISTE-8' of https://github.com/egovernments/punjab-mgram…
chinmoy-eGov 154a215
ISTE-9 Addded Division user and state user type
chinmoy-eGov 75bb0ce
ISTE-9 Addded Division user and state user type
chinmoy-eGov 07540df
Merge pull request #777 from egovernments/ISTE-8
anilsingha-eGov 800fff9
Merge pull request #778 from egovernments/ISTE-9
anilsingha-eGov 7c2778a
ISTE-20: Fixed count not reflecting
anilsingha-eGov 7421dad
ISTE-20: Fixed count not reflecting ( #779 )
anilsingha-eGov 2faae33
ISTE-9 changes in top bar for type of user
chinmoy-eGov 2b9459f
ISTE-9 changes in top bar for type of user ( #780 )
anilsingha-eGov 1929fe4
ISTE-10 Validation added while creating employee
chinmoy-eGov f2ae513
ISTE-10 Validation added while creating employee ( #781 )
anilsingha-eGov 175514d
ISTE-8 Modification in Multiselect dropdown
chinmoy-eGov 2b54487
ISTE-8 Modification in Multiselect dropdown (#782)
anilsingha-eGov 40b048f
ISTE-8 Modified Tag for Division user
chinmoy-eGov 51f872c
ISTE-8 Modified Tag for Division user ( #783 )
anilsingha-eGov ce1b545
ISTE-8 Modification in all select for Multiselect
chinmoy-eGov acca060
ISTE-8 Modification in all select for Multiselect ( #784 )
anilsingha-eGov 76aad43
ISTE-22 Modification in Change city dropdown
chinmoy-eGov 6674f41
ISTE-22 Modification in Change city dropdown ( #785 )
anilsingha-eGov 5147e08
ISTE-11: Added css to hide breadcrum
anilsingha-eGov 9c606c8
ISTE-11: Added css to hide breadcrum ( #787 )
anilsingha-eGov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -10,6 +10,8 @@ const stringReplaceAll = (str = "", searcher = "", replaceWith = "") => { | |||||||||
return str; | ||||||||||
}; | ||||||||||
|
||||||||||
|
||||||||||
|
||||||||||
const ChangeCity = (prop) => { | ||||||||||
const [dropDownData, setDropDownData] = useState({ | ||||||||||
label: `TENANT_TENANTS_${stringReplaceAll(Digit.SessionStorage.get("Employee.tenantId"), ".", "_")?.toUpperCase()}`, | ||||||||||
|
@@ -21,6 +23,12 @@ const ChangeCity = (prop) => { | |||||||||
const isDropdown = prop.dropdown || false; | ||||||||||
let selectedCities = []; | ||||||||||
|
||||||||||
const uuids = [prop.userDetails?.info?.uuid]; | ||||||||||
const { data: userData, isUserDataLoading } = Digit.Hooks.useUserSearch(Digit.ULBService.getStateId(), { uuid: uuids }, {}); | ||||||||||
// setSelectedCity(userData?.data?.user[0]?.roles) | ||||||||||
|
||||||||||
|
||||||||||
|
||||||||||
const { data: data = {}, isLoading } = | ||||||||||
Digit.Hooks.hrms.useHrmsMDMS(Digit.ULBService.getCurrentTenantId(), "egov-hrms", "HRMSRolesandDesignation") || {}; | ||||||||||
|
||||||||||
|
@@ -43,9 +51,8 @@ const ChangeCity = (prop) => { | |||||||||
|
||||||||||
useEffect(() => { | ||||||||||
const userloggedValues = Digit.SessionStorage.get("citizen.userRequestObject"); | ||||||||||
let teantsArray = [], | ||||||||||
filteredArray = []; | ||||||||||
userloggedValues?.info?.roles?.forEach((role) => teantsArray.push(role.tenantId)); | ||||||||||
let teantsArray = [],filteredArray = []; | ||||||||||
userData?.user[0].roles?.forEach((role) => teantsArray.push(role.tenantId)); | ||||||||||
Comment on lines
+54
to
+55
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Optimize the role filtering logic to avoid potential performance issues with large user roles arrays. - userData?.user[0].roles?.forEach((role) => teantsArray.push(role.tenantId));
+ teantsArray = userData?.user[0]?.roles?.map(role => role.tenantId) || []; Committable suggestion
Suggested change
|
||||||||||
let unique = teantsArray.filter((item, i, ar) => ar.indexOf(item) === i); | ||||||||||
|
||||||||||
unique?.forEach((uniCode) => { | ||||||||||
|
@@ -69,7 +76,6 @@ const ChangeCity = (prop) => { | |||||||||
setSelectCityData(filteredArray); | ||||||||||
}, [dropDownData, data?.MdmsRes]); | ||||||||||
|
||||||||||
// if (isDropdown) { | ||||||||||
return ( | ||||||||||
<div style={prop?.mobileView ? { color: "#767676" } : {}}> | ||||||||||
<Dropdown | ||||||||||
|
@@ -79,35 +85,11 @@ const ChangeCity = (prop) => { | |||||||||
selected={dropDownData} | ||||||||||
optionKey={"label"} | ||||||||||
select={handleChangeCity} | ||||||||||
// freeze={true} | ||||||||||
// noBorder={true} | ||||||||||
optionCardStyles={{ overflow: "revert", display: "table" }} | ||||||||||
// customSelector={ | ||||||||||
// <label className="cp"> | ||||||||||
// {prop?.t(`TENANT_TENANTS_${stringReplaceAll(Digit.SessionStorage.get("Employee.tenantId"), ".", "_")?.toUpperCase()}`)} | ||||||||||
// </label> | ||||||||||
// } | ||||||||||
/> | ||||||||||
</div> | ||||||||||
); | ||||||||||
// } else { | ||||||||||
// return ( | ||||||||||
// <React.Fragment> | ||||||||||
// <div style={{ marginBottom: "5px" }}>City</div> | ||||||||||
// <div className="language-selector" style={{display: "flex", flexWrap: "wrap"}}> | ||||||||||
// {selectCityData?.map((city, index) => ( | ||||||||||
// <div className="language-button-container" key={index}> | ||||||||||
// <CustomButton | ||||||||||
// selected={city.value === Digit.SessionStorage.get("Employee.tenantId")} | ||||||||||
// text={city.label} | ||||||||||
// onClick={() => handleChangeCity(city)} | ||||||||||
// ></CustomButton> | ||||||||||
// </div> | ||||||||||
// ))} | ||||||||||
// </div> | ||||||||||
// </React.Fragment> | ||||||||||
// ); | ||||||||||
// } | ||||||||||
|
||||||||||
}; | ||||||||||
|
||||||||||
export default ChangeCity; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review the necessity of
!important
in CSS.The use of
!important
can make CSS maintenance challenging, as it overrides any other styles regardless of specificity. If possible, consider restructuring your CSS to avoid its use, unless absolutely necessary for overriding styles from external libraries.