[pull] main from microsoft:main #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This is technically not to spec, as we should be using FLT_MAX here. However, since CSGO (d3d9 version) was found to expect non-FLT_MAX values when doing an rcp of 0, we're going to keep the out of spec approach. We do need the special handling for when src0 has modifiers on it though as movc doesn't support that.
Co-authored-by: Jesse Natalie <jenatali@microsoft.com>
[Translate_RCP] Handle modifiers on src0 before performing movc The rcp instruction is allowed to have modifiers on src0, such as _abs. When we perform the translation, src0 gets passed as the comparison param for movc, which is not allowed to have modifiers. When we detect that src0 has modifiers present, we need to handle that by doign a mov into a temp register. This was actually done in #51 , but when CSGO was found to have rendering issues after the changes the movc fix got reverted too (#55 ). This PR brings back the movc fixes from those earlier PRs, but doesn't pick up the change to use FLT_MAX. This is technically not to spec, as we should be using FLT_MAX here. However, since CSGO (d3d9 version) was found to expect non-FLT_MAX values when doing an rcp of 0, we're going to keep the out of spec approach in case other apps have the same expectation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )