Skip to content

Conversation

@fbordeu
Copy link
Contributor

@fbordeu fbordeu commented Nov 28, 2024

Update code to support python 3.13, numpy 1 and cython 3.
Update documentation with the new url of the project

Maki4748 and others added 4 commits November 28, 2024 09:52
- Added Macro in setup.py to force new numpy api
- Replaced code belonging to old numpy api
- Fixed Build Problems on Cython>=3.0.0 and Numpy>=2.0.0
- Replaced np.npy_clongdouble with long double complex to fix compilation issues
- Fixed dtypes that broke due to Numpy 2.0.0
@fbordeu fbordeu changed the title Update cython numpy Update Cython 3 and Numpy 2 Nov 29, 2024
@fbordeu
Copy link
Contributor Author

fbordeu commented Nov 29, 2024

@Maki4748 I was finally able to pass all the tests. Can you test on your side to see if it's good for you.

I had a lot of problems with the numpy 1 & 2 compatibility and the support for windows and linux these are my findings.

the size of np.dtype('int')
            np1  np2
on win     32    64
on linux   64    64 

the size of np.dtype('long')
            np1  np2
on win     32    32
on linux   64    64 

The names of the type and the sizes are not verry clear. I'm not verry proud of the code so dont hesitate to make comment on it.

@Maki4748
Copy link
Contributor

@fbordeu Yeah, I figured we need to deal with this properly at some point, I tried around and since char, short, long and long long are basically just int with a different width, I changed it up to the proper c int types with defined width, and the tests at least on windows are passing.
Types like np.long should just get resolved to the platfrom specific implementation then hopefully anyway.

Could you merge this for now?
I'll rebase my code onto it and create a pull request then

@fbordeu fbordeu merged commit fd9c416 into eigency-org:master Nov 29, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants