Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goerli tests #562

Merged
merged 41 commits into from
Jan 22, 2024
Merged

Goerli tests #562

merged 41 commits into from
Jan 22, 2024

Conversation

tonypony220
Copy link
Contributor

@tonypony220 tonypony220 commented Jan 11, 2024 •
edited
Loading

Issue Number: #553

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Refactoring test to fit JSON-RPC 6.0 spec
Adding tests for testnet goerli

Breaking changes?

  • yes
  • no

tonypony220 and others added 30 commits December 31, 2023 02:14
@tonypony220
updated deps
dd86bed
@tonypony220
added new methods
2086f69
@tonypony220
added specVersion to README
9a51602
@tonypony220
expose data from starknet errors
2957166
@tonypony220
clean up
df50649
@tonypony220
fix typo
450dfe9
@tonypony220
refactor to return hex
86a5bc3
@tonypony220
clean up
babc36a
@tonypony220
switch realese bin build on ubuntu-20.04
5432422
@tonypony220
switch workflows on ubuntu-20.04
a52ec30
@tonypony220
Revert "switch realese bin build on ubuntu-20.04"
46700a8 
This reverts commit 9fff367.
@tonypony220
switch to musl build
7aef11a
@tonypony220
fix
9ff15ee
@tonypony220
use container for build
76a8151
@tonypony220
use container for build
07b8570
@tonypony220
use container for build
cdd859f
@tonypony220
use container for build
bc81b1c
@tonypony220
use container for build
055efc1
@tonypony220
use container for build
6ced9a6
@tonypony220
use container for build
a7007fe
@tonypony220
del workflow dispatch
818c282
@tonypony220
try with kill in CI job
e1d265f
@tonypony220
update hurl install
40760a0
@tonypony220
cache target
abd352c
@tonypony220
check killing works
0380d09
@tonypony220
added right codes
39d53f4
@tonypony220
workflow dispatch
0cbf3c0
@tonypony220
playing around
a3b508d
@tonypony220
added test gorli declare transaction
efb77d8
@tonypony220
adding tests
4b21c5b
@tonypony220 tonypony220 marked this pull request as ready for review January 12, 2024 14:00
@pierre-l
Copy link
Contributor

Hello @tonypony220!
The announcement is still pending but you may have already noticed the repo has been transferred.
I'll take a look at you work tomorrow :)

Base automatically changed from hex-api to main January 18, 2024 18:49
@tonypony220 tonypony220 requested review from pierre-l and removed request for drspacemn January 18, 2024 19:08
@pierre-l
Copy link
Contributor

That's awesome work!
I'll take a deeper look at the check failure on Monday.

@pierre-l
Sync the README.md with the main branch
a79dca7
@pierre-l
Sync the README.md with the main branch
1dbea5b 
Keep using "jsonrpc" instead of "openrpc" just to avoid the conflict with the main branch
@pierre-l
Copy link
Contributor

With the goerli_helios_json fix already in main while being the only check failure here, I'm merging this.

@pierre-l pierre-l merged commit 79f8f37 into main Jan 22, 2024
3 of 4 checks passed
@pierre-l pierre-l deleted the goerli-tests branch January 22, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierre-l pierre-l pierre-l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonypony220 @pierre-l