Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typetools/checker-framework 3.43.0 release #1079

Merged
merged 173 commits into from
Jan 30, 2025

Conversation

wmdietl
Copy link
Member

@wmdietl wmdietl commented Jan 30, 2025

No description provided.

wmdietl and others added 30 commits January 29, 2025 17:35
Fixes typetools#6297

We make two key changes:

1. Split formatting of `.java` source files among individual sub-projects, so formatting / checking for each sub-project can run in parallel.
2. Remove exclusion patterns that start in `**`, which are expensive to evaluate.

With these changes, `./gradlew spotlessCheck` (which runs in the pre-commit script) runs much faster for me (on my M1 Mac the running time is reduced from ~9.2 seconds before this PR to ~2 seconds after).

To test, we add tasks named `printSpotlessTaskInputs` that print which files are being formatted.  Using these tasks I confirmed that exactly the same files are being checked and formatted before and after this PR.
…ols#6384)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Ernst <mernst@cs.washington.edu>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@wmdietl
Copy link
Member Author

wmdietl commented Jan 30, 2025

Everything compiles, but tests crash with an exception. Opening the PR to keep changes separate and make review easier.

@wmdietl wmdietl merged commit 0418629 into typetools-3.43.0-fixes Jan 30, 2025
4 of 15 checks passed
@wmdietl wmdietl deleted the typetools-3.43.0-merge branch January 30, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants